planner: fix insert with select the same table result no error #issue 31363

errors.toml

@@ -2146,6 +2146,11 @@ error = '''
 Not unique table/alias: '%-.192s'
 '''
 
+["planner:1093"]
+error = '''
+You can't specify target table '%-.192s' for update in FROM clause
+'''
+
 ["planner:1094"]
 error = '''
 Unknown thread id: %d

executor/insert_test.go

@@ -1489,6 +1489,9 @@ func TestInsertIntoSelectError(t *testing.T) {
 	tk.MustQuery("SHOW WARNINGS;").Check(testkit.Rows("Warning 1210 Incorrect arguments to sleep"))
 	tk.MustExec("INSERT IGNORE into t1(SELECT SLEEP(1));")
 	tk.MustQuery("SELECT * FROM t1;").Check(testkit.Rows("0", "0", "0"))
+	tk.MustExec("TRUNCATE t1;")
+	tk.MustGetErrCode("INSERT INTO t1 (a) VALUES ((SELECT a FROM t1));", errno.ErrUpdateTableUsed)
+	tk.MustExec("INSERT INTO t1 (a) VALUES ((SELECT a FROM t1 as t));")
 	tk.MustExec("DROP TABLE t1;")
 }
 

planner/core/errors.go

@@ -119,4 +119,5 @@ var (
 	ErrPrepareDDL       = dbterror.ClassExecutor.NewStd(mysql.ErrPrepareDDL)
 	ErrRowIsReferenced2 = dbterror.ClassOptimizer.NewStd(mysql.ErrRowIsReferenced2)
 	ErrNoReferencedRow2 = dbterror.ClassOptimizer.NewStd(mysql.ErrNoReferencedRow2)
+	ErrUpdateTableUsed  = dbterror.ClassOptimizer.NewStd(mysql.ErrUpdateTableUsed)
 )

planner/core/errors_test.go

@@ -83,6 +83,7 @@ func TestError(t *testing.T) {
 		ErrStmtNotFound,
 		ErrAmbiguous,
 		ErrKeyPart0,
+		ErrUpdateTableUsed,
 	}
 	for _, err := range kvErrs {
 		code := terror.ToSQLError(err).Code

planner/core/expression_rewriter.go

@@ -124,7 +124,7 @@ func (b *PlanBuilder) rewriteWithPreprocess(
 	p LogicalPlan, aggMapper map[*ast.AggregateFuncExpr]int,
 	windowMapper map[*ast.WindowFuncExpr]int,
 	asScalar bool,
-	preprocess func(ast.Node) ast.Node,
+	preprocess func(ast.Node) (ast.Node, error),
 ) (expression.Expression, LogicalPlan, error) {
 	b.rewriterCounter++
 	defer func() { b.rewriterCounter-- }()
@@ -233,7 +233,7 @@ type expressionRewriter struct {
 	asScalar bool
 
 	// preprocess is called for every ast.Node in Leave.
-	preprocess func(ast.Node) ast.Node
+	preprocess func(ast.Node) (ast.Node, error)
 
 	// insertPlan is only used to rewrite the expressions inside the assignment
 	// of the "INSERT" statement.
@@ -1149,7 +1149,12 @@ func (er *expressionRewriter) Leave(originInNode ast.Node) (retNode ast.Node, ok
 	}
 	var inNode = originInNode
 	if er.preprocess != nil {
-		inNode = er.preprocess(inNode)
+		nd, err := er.preprocess(inNode)
+		inNode = nd
+		if err != nil {
+			er.err = err
+			return retNode, false
+		}
 	}
 	switch v := inNode.(type) {
 	case *ast.AggregateFuncExpr, *ast.ColumnNameExpr, *ast.ParenthesesExpr, *ast.WhenClause,

planner/core/logical_plan_builder.go

@@ -6066,17 +6066,17 @@ func (b *PlanBuilder) buildUpdateLists(ctx context.Context, tableList []*ast.Tab
 			dependentColumnsModified[col.UniqueID] = true
 		} else {
 			// rewrite with generation expression
-			rewritePreprocess := func(assign *ast.Assignment) func(expr ast.Node) ast.Node {
-				return func(expr ast.Node) ast.Node {
+			rewritePreprocess := func(assign *ast.Assignment) func(expr ast.Node) (ast.Node, error) {
+				return func(expr ast.Node) (ast.Node, error) {
 					switch x := expr.(type) {
 					case *ast.ColumnName:
 						return &ast.ColumnName{
 							Schema: assign.Column.Schema,
 							Table:  assign.Column.Table,
 							Name:   x.Name,
-						}
+						}, nil
 					default:
-						return expr
+						return expr, nil
 					}
 				}
 			}

planner/core/planbuilder.go

@@ -3907,15 +3907,54 @@ func (b *PlanBuilder) buildInsert(ctx context.Context, insert *ast.InsertStmt) (
 	mockTablePlan.SetSchema(insertPlan.tableSchema)
 	mockTablePlan.names = insertPlan.tableColNames
 
-	checkRefColumn := func(n ast.Node) ast.Node {
+	checkTblName := func(n ast.Node) error {
+		source := n.(*ast.TableSource).Source
+		if src, ok := source.(*ast.TableName); ok {
+			subTblname := src.Name
+			srcTblname := tn.Name
+			subAsName := n.(*ast.TableSource).AsName
+
+			if srcTblname == subTblname && subAsName.O == "" {
+				err := ErrUpdateTableUsed.GenWithStackByArgs(srcTblname.O)
+				return err
+			}
+		}
+		return nil
+	}
+
+	checkRefColumn := func(n ast.Node) (ast.Node, error) {
 		if insertPlan.NeedFillDefaultValue {
-			return n
+			return n, nil
 		}
 		switch n.(type) {
 		case *ast.ColumnName, *ast.ColumnNameExpr:
 			insertPlan.NeedFillDefaultValue = true
+		case *ast.SubqueryExpr:
+			sel := n.(*ast.SubqueryExpr).Query
+			switch sel.(type) {
+			case *ast.SelectStmt:
+				if sel.(*ast.SelectStmt).From != nil {
+					left := sel.(*ast.SelectStmt).From.TableRefs.Left
+					switch lnode := left.(type) {
+					case *ast.Join:
+						err := checkTblName(lnode.Left)
+						if err != nil {
+							return n, err
+						}
+						err = checkTblName(lnode.Right)
+						if err != nil {
+							return n, err
+						}
+					case *ast.TableSource:
+						err = checkTblName(lnode)
+						if err != nil {
+							return n, err
+						}
+					}
+				}
+			}
 		}
-		return n
+		return n, nil
 	}
 
 	if len(insert.Lists) > 0 {
@@ -4038,7 +4077,7 @@ func (*PlanBuilder) getAffectCols(insertStmt *ast.InsertStmt, insertPlan *Insert
 	return affectedValuesCols, nil
 }
 
-func (b PlanBuilder) getInsertColExpr(ctx context.Context, insertPlan *Insert, mockTablePlan *LogicalTableDual, col *table.Column, expr ast.ExprNode, checkRefColumn func(n ast.Node) ast.Node) (outExpr expression.Expression, err error) {
+func (b PlanBuilder) getInsertColExpr(ctx context.Context, insertPlan *Insert, mockTablePlan *LogicalTableDual, col *table.Column, expr ast.ExprNode, checkRefColumn func(n ast.Node) (ast.Node, error)) (outExpr expression.Expression, err error) {
 	if col.Hidden {
 		return nil, ErrUnknownColumn.GenWithStackByArgs(col.Name, clauseMsg[fieldList])
 	}
@@ -4100,7 +4139,7 @@ func (b PlanBuilder) getInsertColExpr(ctx context.Context, insertPlan *Insert, m
 	return outExpr, nil
 }
 
-func (b *PlanBuilder) buildValuesListOfInsert(ctx context.Context, insert *ast.InsertStmt, insertPlan *Insert, mockTablePlan *LogicalTableDual, checkRefColumn func(n ast.Node) ast.Node) error {
+func (b *PlanBuilder) buildValuesListOfInsert(ctx context.Context, insert *ast.InsertStmt, insertPlan *Insert, mockTablePlan *LogicalTableDual, checkRefColumn func(n ast.Node) (ast.Node, error)) error {
 	affectedValuesCols, err := b.getAffectCols(insert, insertPlan)
 	if err != nil {
 		return err

planner/core/planbuilder_test.go

@@ -121,7 +121,7 @@ func TestRewriterPool(t *testing.T) {
 	dirtyRewriter := builder.getExpressionRewriter(context.TODO(), nil)
 	dirtyRewriter.asScalar = true
 	dirtyRewriter.aggrMap = make(map[*ast.AggregateFuncExpr]int)
-	dirtyRewriter.preprocess = func(ast.Node) ast.Node { return nil }
+	dirtyRewriter.preprocess = func(ast.Node) (ast.Node, error) { return nil, nil }
 	dirtyRewriter.insertPlan = &Insert{}
 	dirtyRewriter.disableFoldCounter = 1
 	dirtyRewriter.ctxStack = make([]expression.Expression, 2)