Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: fix the missing retry for pd batch scan error #33420

Merged
merged 10 commits into from
Mar 25, 2022
Merged

br: fix the missing retry for pd batch scan error #33420

merged 10 commits into from
Mar 25, 2022

Conversation

3pointer
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #33419

Problem Summary:
current BR doesn't not retry ErrPDBatchScanRegion enough.

What is changed and how it works?

replace the multierr with the ErrPDBatchScanRegion

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the issue that BR not retry enough when region not consistency during restoration.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 25, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • gozssky
  • joccau

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed labels Mar 25, 2022
@3pointer 3pointer requested a review from joccau March 25, 2022 05:39
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 25, 2022
@3pointer 3pointer requested review from YuJuncen and joccau and removed request for joccau March 25, 2022 05:39
@sre-bot
Copy link
Contributor

sre-bot commented Mar 25, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/2440b78a2a82d75ad8d1f075fdd54f26eb613c58

joccau
joccau approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM～

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 25, 2022
@joccau
Copy link
Member

joccau commented Mar 25, 2022

/component br

@ti-chi-bot ti-chi-bot added the component/br This issue is related to BR of TiDB. label Mar 25, 2022
@joccau
Copy link
Member

joccau commented Mar 25, 2022

/run-integration-br-test

@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 25, 2022
@3pointer
Copy link
Contributor Author

/merge

@ti-chi-bot ti-chi-bot merged commit 9129590 into pingcap:master Mar 25, 2022
@3pointer
Copy link
Contributor Author

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 25, 2022
@3pointer @ti-srebot
cherry pick pingcap#33420 to release-4.0
ec17ad9 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 25, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #33464

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 25, 2022
@3pointer @ti-srebot
cherry pick pingcap#33420 to release-5.0
80ca145 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 25, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #33466

@ti-srebot ti-srebot mentioned this pull request Mar 25, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 25, 2022
@3pointer @ti-srebot
cherry pick pingcap#33420 to release-5.1
4ceb098 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #33467

@ti-srebot ti-srebot mentioned this pull request Mar 25, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 25, 2022
@3pointer @ti-srebot
cherry pick pingcap#33420 to release-5.2
7daa92f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #33468

@ti-srebot ti-srebot mentioned this pull request Mar 25, 2022
Merged
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 25, 2022
@3pointer @ti-srebot
cherry pick pingcap#33420 to release-5.3
b45c405 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #33469

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 25, 2022
@3pointer @ti-srebot
cherry pick pingcap#33420 to release-5.4
20c9fb3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 25, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #33470

@ti-srebot ti-srebot mentioned this pull request Mar 25, 2022
Merged
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 25, 2022
@3pointer @ti-srebot
cherry pick pingcap#33420 to release-6.0
3219ba3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33471

ti-chi-bot pushed a commit that referenced this pull request Mar 28, 2022
@ti-srebot
br: fix the missing retry for pd batch scan error (#33420) (#33471)
4bd69a7 
close #33419
ti-chi-bot pushed a commit that referenced this pull request Apr 28, 2022
@ti-srebot
br: fix the missing retry for pd batch scan error (#33420) (#33470)
c53fe3d 
close #33419
ti-chi-bot pushed a commit that referenced this pull request Jun 17, 2022
@ti-srebot
br: fix the missing retry for pd batch scan error (#33420) (#33469)
60c9ee7 
close #33419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glorv glorv glorv approved these changes

@sleepymole sleepymole sleepymole approved these changes

@zhouqiang-cl zhouqiang-cl zhouqiang-cl approved these changes

@joccau joccau joccau approved these changes

@YuJuncen YuJuncen Awaiting requested review from YuJuncen

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/br This issue is related to BR of TiDB. needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scan region retry not work as expected.
10 participants
@3pointer @ti-chi-bot @sre-bot @joccau @hawkingrei @ti-srebot @glorv @sleepymole @zhouqiang-cl @VelocityLight