-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix bug that UnionScan can't keep order caused wrong result (#33218) #33319
*: fix bug that UnionScan can't keep order caused wrong result (#33218) #33319
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@tiancaiamao you're already a collaborator in bot's repo. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 9e50c98
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-unit-test |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/cb9024a8887037f578f259ceaf59a8824a442dfe |
cherry-pick #33218 to release-6.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/33319
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #33175
Problem Summary:
What is changed and how it works?
Actually, there are two bugs that cause the UnionScan fail to keep order,
and since it can't keep order, the following plan return wrong result.
Limit1->UnionScan->XXX
doesn't return themax(id)
The first bug is the datum comparing, the data type is KindUint64, but the old code treat it as
GetInt64()
,10353107668348738101 become a negative number and 10353107668348738101 < 33
The second bug is the handling of kv range, in TiKV, the range is singed int
Here the data type is uint, so correct range handling is:
the wrong range handling is:
i.e. the kv range order should be [-max int64, 0] [0, max int64]
Check List
Tests
Side effects
Documentation
Release note