Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client-go: fix race in backoffer #33291

Merged
merged 1 commit into from
Mar 22, 2022
Merged

client-go: fix race in backoffer #33291

merged 1 commit into from
Mar 22, 2022

Conversation

cfzjywxk
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #33265

Problem Summary:
Cherry-pick #33290 to release-6.0.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@cfzjywxk cfzjywxk added type/bugfix This PR fixes a bug. fixes-6.0.0 labels Mar 21, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • you06
  • youjiali1995

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 21, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 21, 2022
@hawkingrei
Copy link
Member

/run-check_dev

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 21, 2022
@hawkingrei
Copy link
Member

/run-check_dev

@cfzjywxk
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: be6754b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 22, 2022
@cfzjywxk
Copy link
Contributor Author

@VelocityLight
PTAL need cherry-pick approve label, thx

@cfzjywxk
Copy link
Contributor Author

/run-mysql-test

@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 22, 2022
@VelocityLight
Copy link

/merge

@cfzjywxk
Copy link
Contributor Author

/run-mysql-test

2 similar comments
@cfzjywxk
Copy link
Contributor Author

/run-mysql-test

@cfzjywxk
Copy link
Contributor Author

/run-mysql-test

@cfzjywxk
Copy link
Contributor Author

/merge

2 similar comments
@cfzjywxk
Copy link
Contributor Author

/merge

@cfzjywxk
Copy link
Contributor Author

/merge

@cfzjywxk cfzjywxk mentioned this pull request Mar 22, 2022
Closed
1 task
@purelind
Copy link
Contributor

/run-mysql-test

@cfzjywxk
Copy link
Contributor Author

/run-check_dev

1 similar comment
@cfzjywxk
Copy link
Contributor Author

/run-check_dev

@purelind
Copy link
Contributor

/run-check_dev
/run-unit-test

@purelind
Copy link
Contributor

/run-check_dev

1 similar comment
@cfzjywxk
Copy link
Contributor Author

/run-check_dev

@cfzjywxk
Copy link
Contributor Author

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Mar 22, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/be6754b511fb3732c6ab3e5df3f329658844ee4a

@ti-chi-bot ti-chi-bot merged commit 3fa3e0e into pingcap:release-6.0 Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youjiali1995 youjiali1995 youjiali1995 approved these changes

@you06 you06 you06 approved these changes

@longfangsong longfangsong Awaiting requested review from longfangsong

@sticnarf sticnarf Awaiting requested review from sticnarf

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. fixes-6.0.0 release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cfzjywxk @ti-chi-bot @hawkingrei @VelocityLight @purelind @sre-bot @you06 @youjiali1995