Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add a global system variable to control the memory quota for the bindCache #32613

Merged
merged 7 commits into from
Mar 1, 2022

Conversation

Reminiscent
Copy link
Contributor

…indCache

What problem does this PR solve?

Issue Number: ref #32466

Problem Summary:
add a global system variable to control the memory quota for the bindCache

What is changed and how it works?

Introduce a global-level system variable

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@Reminiscent Reminiscent requested review from morgo and qw4990 February 24, 2022 08:56
@Reminiscent Reminiscent requested a review from a team as a code owner February 24, 2022 08:56
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 24, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • morgo
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 24, 2022
@Reminiscent
Copy link
Contributor Author

@morgo PTAL, thanks~

@sre-bot
Copy link
Contributor

sre-bot commented Feb 25, 2022

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 28, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 1, 2022
@qw4990
Copy link
Contributor

qw4990 commented Mar 1, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ec9a54b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 1, 2022
@Reminiscent
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 8134942 into pingcap:master Mar 1, 2022
@Reminiscent Reminiscent deleted the MemQuotaBindCache branch March 1, 2022 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants