Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: Fix backup rawkv failure #32612

Merged
merged 13 commits into from
Mar 3, 2022
Merged

br: Fix backup rawkv failure #32612

merged 13 commits into from
Mar 3, 2022

Conversation

pingyu
Copy link
Contributor

@pingyu pingyu commented Feb 24, 2022

What problem does this PR solve?

Issue Number: close #32607

Problem Summary:
A failure happened when BR backup rawkv.

What is changed and how it works?

Set IsRawKv = true for fineGrainedBackup and related procedures.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Side effects
No.

Documentation
No.

Release note

Fix BR failure on backup rawkv.

Other note

There is still an issue when backup the whole range of rawkv, and will be fixed in another PR. To word around, set arguments as --start 00 --format hex

@pingyu
br: Fix failure on rawkv backup
1d5d7d6 
Issue Number: pingcap#32607

Signed-off-by: pingyu <yuping@pingcap.com>
@pingyu
br: Fix failure on rawkv backup
2ab839d 
Issue Number: close pingcap#32607

Signed-off-by: pingyu <yuping@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • fengou1

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 24, 2022
@pingyu
Copy link
Contributor Author

pingyu commented Feb 24, 2022

/run-integration-br-test

@pingyu
Copy link
Contributor Author

pingyu commented Feb 25, 2022

/run-integration-br-test

@3pointer
Copy link
Contributor

/run-all-tests

@3pointer
Copy link
Contributor

/run-integration-br-test

@sre-bot
Copy link
Contributor

sre-bot commented Feb 25, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/fb8e5f744fefab6d091607d3c537cf5aa6644034

@3pointer
Copy link
Contributor

/run-integration-br-test

1 similar comment
@3pointer
Copy link
Contributor

/run-integration-br-test

@3pointer
Copy link
Contributor

/run-integration-br-test

@3pointer
Copy link
Contributor

3pointer commented Mar 1, 2022

/run-integration-br-test

3pointer
3pointer reviewed Mar 1, 2022
View reviewed changes
@pingyu
br: fix br raw backup
5237bbd 
Issue Number: close pingcap#32607

Signed-off-by: pingyu <yuping@pingcap.com>
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 1, 2022
@ti-chi-bot ti-chi-bot merged commit 4e69c07 into pingcap:master Mar 3, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 3, 2022
@pingyu @ti-srebot
cherry pick pingcap#32612 to release-4.0
2d65159 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 3, 2022
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #32786

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 3, 2022
@pingyu @ti-srebot
cherry pick pingcap#32612 to release-5.0
099a824 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 3, 2022
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #32789

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 3, 2022
@pingyu @ti-srebot
cherry pick pingcap#32612 to release-5.1
8dd5a3c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 3, 2022
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #32790

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 3, 2022
@pingyu @ti-srebot
cherry pick pingcap#32612 to release-5.2
919ecb7 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 3, 2022
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #32791

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 3, 2022
@pingyu @ti-srebot
cherry pick pingcap#32612 to release-5.3
0e8d8d1 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 3, 2022
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #32792

@ti-srebot ti-srebot mentioned this pull request Mar 3, 2022
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #32793

@pingyu pingyu mentioned this pull request Mar 21, 2022
Closed
12 tasks
@pingyu pingyu mentioned this pull request Mar 28, 2022
Merged
ti-chi-bot pushed a commit that referenced this pull request Apr 15, 2022
@ti-srebot
br: Fix backup rawkv failure (#32612) (#32791)
10391fa 
close #32607
joccau pushed a commit to ti-srebot/tidb that referenced this pull request Apr 28, 2022
@pingyu @joccau
cherry pick pingcap#32612 to release-5.4
4f6d089 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-chi-bot pushed a commit that referenced this pull request Apr 28, 2022
@ti-srebot
br: Fix backup rawkv failure (#32612) (#32793)
d1eac99 
close #32607
ti-chi-bot pushed a commit that referenced this pull request Jun 17, 2022
@ti-srebot
br: Fix backup rawkv failure (#32612) (#32792)
d835c45 
close #32607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3pointer 3pointer 3pointer approved these changes

@joccau joccau joccau approved these changes

@fengou1 fengou1 fengou1 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

br: rawkv backup failed
8 participants
@pingyu @ti-chi-bot @3pointer @sre-bot @joccau @ti-srebot @fengou1 @YuJuncen