Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

variable: refine comments of variables #32611

Merged
merged 4 commits into from
Feb 25, 2022
Merged

variable: refine comments of variables #32611

merged 4 commits into from
Feb 25, 2022

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Feb 24, 2022

Signed-off-by: Jack Yu jackysp@gmail.com

What problem does this PR solve?

Issue Number: close #32609

Problem Summary: A lot of code comments in tidb are not in line with Golang code style in tidb_vars.go.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@jackysp
variable: refine comments of variables
02dd0e7 
Signed-off-by: Jack Yu <jackysp@gmail.com>
@jackysp jackysp requested a review from a team as a code owner February 24, 2022 07:57
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ekexium
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 24, 2022
@jackysp jackysp requested review from ekexium and coocood February 24, 2022 07:58
ekexium
ekexium approved these changes Feb 24, 2022
View reviewed changes
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 24, 2022
@jackysp @ekexium
Update sessionctx/variable/tidb_vars.go
2ed8125 
Co-authored-by: Ziqian Qin <ekexium@gmail.com>
@sre-bot
Copy link
Contributor

sre-bot commented Feb 24, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/c1699ff5eca8d84139b74e5fe3e49622b5e4238f

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 24, 2022
@tangenta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2ed8125

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 24, 2022
@hawkingrei
Copy link
Member

/run-unit-test

@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@hawkingrei: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei
Copy link
Member

@XuHuaiyu @qw4990 PTAL

@jackysp
Copy link
Member Author

jackysp commented Feb 25, 2022

/merge

@cfzjywxk
Copy link
Contributor

/merge

@ti-chi-bot ti-chi-bot merged commit e389170 into pingcap:master Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@tangenta tangenta tangenta approved these changes

@ekexium ekexium ekexium approved these changes

@coocood coocood Awaiting requested review from coocood

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code comments not in Golang code style
7 participants
@jackysp @ti-chi-bot @sre-bot @tangenta @hawkingrei @cfzjywxk @ekexium