Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stmtsummary: issue left in #32156 #32427

Merged
merged 11 commits into from
Feb 21, 2022
Merged

stmtsummary: issue left in #32156 #32427

merged 11 commits into from
Feb 21, 2022

Conversation

LemonHX
Copy link
Contributor

@LemonHX LemonHX commented Feb 17, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #32156

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test

Release note

None

@LemonHX
change columnValueFactory function signature with reader included.
eb9e0ae 
Signed-off-by: lemonhx <lemonhx@lemonhx.tech>
@LemonHX
first seen and last seen using user timezone
d928908 
Signed-off-by: lemonhx <lemonhx@lemonhx.tech>
@LemonHX
fix unit test
caffbd8 
Signed-off-by: lemonhx <lemonhx@lemonhx.tech>
@LemonHX
write unit test
7813a0c 
Signed-off-by: lemonhx <lemonhx@lemonhx.tech>
@LemonHX
does the same thing on summary begin/end time.
cffd5ee 
Signed-off-by: lemonhx <lemonhx@lemonhx.tech>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • crazycs520
  • djshow832

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 17, 2022
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 17, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Feb 17, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/4f1de8d56735c64ac8b78bc56ce94d1b70c5392c

@LemonHX
pass unit test
7a1afd3 
Signed-off-by: lemonhx <lemonhx@lemonhx.tech>
@LemonHX
update unit test
458b283 
Signed-off-by: lemonhx <lemonhx@lemonhx.tech>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 17, 2022
@djshow832 djshow832 requested a review from crazycs520 February 17, 2022 10:56
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 18, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 21, 2022
@crazycs520
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4f1de8d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 21, 2022
@ti-chi-bot ti-chi-bot merged commit 5233d2e into pingcap:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 approved these changes

@djshow832 djshow832 djshow832 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

statement table FIRST_SEEN, LAST_SEEN field value is not sync with time_zone variable
5 participants
@LemonHX @ti-chi-bot @sre-bot @crazycs520 @djshow832