executor: fixed comments warning. #3187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhexuany
changed the title
shenli
reviewed
Apr 29, 2017
executor/write.go
Outdated
| @@ -449,6 +449,7 @@ func escapeCols(strs [][]byte) []string { | |||
| return ret | |||
| } | |||
|
|
|||
| // escape ... | |||
There was a problem hiding this comment.
escape handles escape characters when running load data statement.
executor/write.go
Outdated
| @@ -682,6 +683,7 @@ func (e *InsertExec) Close() error { | |||
| return nil | |||
| } | |||
|
|
|||
| // getColumns ... | |||
There was a problem hiding this comment.
getColumns gets the explicitly specified columns of an insert statement. There are three cases:
executor/builder.go
Outdated
| @@ -365,6 +365,7 @@ func (b *executorBuilder) buildUnionScanExec(v *plan.PhysicalUnionScan) Executor | |||
| return us | |||
| } | |||
|
|
|||
| // buildMergeJoin ... | |||
There was a problem hiding this comment.
buildMergeJoin builds SortMergeJoin executor.
executor/show.go
Outdated
| @@ -329,6 +329,7 @@ func (e *ShowExec) fetchShowIndex() error { | |||
| return nil | |||
| } | |||
|
|
|||
| // fetchShowCharset ... | |||
There was a problem hiding this comment.
fetchShowCharset gets all charset information and fill them into e.rows.
zhexuany
force-pushed
the
fixed_comments_in_executor
branch
from
84ab124 to
16ee921
Compare
|
@shenli DONE. PTAL. |
|
LGTM |
shenli
approved these changes
Apr 30, 2017
coocood
reviewed
Apr 30, 2017
executor/adapter.go
Outdated
| @@ -77,7 +77,7 @@ func (a *recordSet) Close() error { | |||
|
|
|||
| // statement implements the ast.Statement interface, it builds a plan.Plan to an ast.Statement. | |||
| type statement struct { | |||
| // The InfoSchema cannot change during execution, so we hold a reference to it. | |||
| // is is the InfoSchema cannot change during execution, so we hold a reference to it. | |||
There was a problem hiding this comment.
// is ...
// The InfoSchema cannot change during execution, so we hold a reference to it.
coocood
reviewed
Apr 30, 2017
executor/merge_join.go
Outdated
| @@ -30,7 +30,7 @@ import ( | |||
| // 2. For other cases its preferred not to use SMJ and operator | |||
| // will throw error. | |||
| type MergeJoinExec struct { | |||
| // Left is always the driver side | |||
There was a problem hiding this comment.
This comment describes several fields below.
coocood
reviewed
Apr 30, 2017
executor/merge_join.go
Outdated
| @@ -43,7 +43,7 @@ type MergeJoinExec struct { | |||
| cursor int | |||
| defaultValues []types.Datum | |||
|
|
|||
| // Default for both side in case full join | |||
coocood
reviewed
Apr 30, 2017
executor/metrics.go
Outdated
| @@ -283,7 +283,7 @@ const ( | |||
| attrAggregate = "Agg" | |||
| ) | |||
|
|
|||
| // Not all attributes is used to create the label, because we don't want too many labels. | |||
coocood
reviewed
Apr 30, 2017
executor/union_scan.go
Outdated
| @@ -66,7 +66,7 @@ func (udb *dirtyDB) getDirtyTable(tid int64) *dirtyTable { | |||
| } | |||
|
|
|||
| type dirtyTable struct { | |||
| // key is handle. | |||
| // addedRows is a map whose key is handle. | |||
There was a problem hiding this comment.
// addedRows ...
// The key is handle.
coocood
reviewed
Apr 30, 2017
executor/write.go
Outdated
| @@ -1091,7 +1093,7 @@ type UpdateExec struct { | |||
| SelectExec Executor | |||
| OrderedList []*expression.Assignment | |||
|
|
|||
| // Map for unique (Table, handle) pair. | |||
| // updatedRowKeys is map for unique (Table, handle) pair. | |||
coocood
reviewed
Apr 30, 2017
executor/distsql.go
Outdated
| @@ -68,7 +68,8 @@ type lookupTableTask struct { | |||
|
|
|||
| // The handles fetched from index is originally ordered by index, but we need handles to be ordered by itself | |||
| // to do table request. | |||
| // The indexOrder map is used to save the original index order for the handles. | |||
|
|
|||
There was a problem hiding this comment.
The above comment is used to comment indexOrder, we should not add an empty line.
coocood
reviewed
Apr 30, 2017
executor/executor.go
Outdated
| @@ -81,6 +81,7 @@ const ( | |||
| codeErrBuildExec terror.ErrCode = 9 | |||
| codeBatchInsertFail terror.ErrCode = 10 | |||
| // MySQL error code | |||
|
|
|||
There was a problem hiding this comment.
Here is the downside of goword, when we need to comment several fields, goword makes it harder to read.
29 tasks
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.