Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner, distsql: fix the Stale Read and Local Txn compatibility #31606

Merged
merged 3 commits into from
Jan 13, 2022
Merged

planner, distsql: fix the Stale Read and Local Txn compatibility #31606

merged 3 commits into from
Jan 13, 2022

Conversation

JmPotato
Copy link
Member

Signed-off-by: JmPotato ghzpotato@gmail.com

What problem does this PR solve?

Issue Number: close #31604

Problem Summary:

Stale Read should not be restricted by the Local Txn's zone check.

What is changed and how it works?

Check IsStaleness before we verify the TxnScope.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

TBD.

Release note

None

@JmPotato
Fix the Stale Read and Local Txn compatibility
6c41460 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 12, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 12, 2022
@JmPotato
Copy link
Member Author

/cc @Yisaer @nolouch @xhebox

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 12, 2022
@xhebox
Copy link
Contributor

xhebox commented Jan 12, 2022

/run-check_dev

@JmPotato
Refine the code and comments
28af64c 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jan 12, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/acbe2899cfcb9e453dc08d693d9ce513ae0eb49a

nolouch
nolouch approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 13, 2022
@JmPotato
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@JmPotato: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xhebox
Copy link
Contributor

xhebox commented Jan 13, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 28af64c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 13, 2022
@ti-chi-bot
Copy link
Member

@JmPotato: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@JmPotato
Copy link
Member Author

/run-check_dev_2

@JmPotato
Copy link
Member Author

/run-unit-test

1 similar comment
@JmPotato
Copy link
Member Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 8ee8826 into pingcap:master Jan 13, 2022
@JmPotato JmPotato deleted the fix_local_txn branch January 13, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@nolouch nolouch nolouch approved these changes

@Yisaer Yisaer Awaiting requested review from Yisaer

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stale Read should not be restricted by the Local Txn's zone check
5 participants
@JmPotato @ti-chi-bot @xhebox @sre-bot @nolouch