Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: make sequence cache-opt mutually exclusive to each other #31362

Merged
merged 8 commits into from
Jan 6, 2022
Merged

ddl: make sequence cache-opt mutually exclusive to each other #31362

merged 8 commits into from
Jan 6, 2022

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Jan 5, 2022 •
edited
Loading

Signed-off-by: ailinkid 314806019@qq.com

What problem does this PR solve?

Issue Number: close #31265

What is changed and how it works?

1: sequence cachevalue(int) and cache(bool) opt should be mutually exclusive to each other when setting or altering.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None

@AilinKid
make sequence cache-opt mutually exclusive to fix the 31265
e53f5ff 
Signed-off-by: ailinkid <314806019@qq.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 5, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 5, 2022
@AilinKid AilinKid changed the title ddl: make sequence cache-opt mutually exclusive to fix the 31265 ddl: make sequence cache-opt mutually exclusive to each other Jan 5, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jan 5, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/b31fad164b54466d9248530fd67baf9f5a025bc2

djshow832
djshow832 reviewed Jan 6, 2022
View reviewed changes
ddl/sequence_test.go Show resolved Hide resolved
ddl/sequence_test.go

tk := testkit2.NewTestKit(t, store)
tk.MustExec("use test")
tk.MustExec("create sequence seq cache=1 nocache")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cache=1 conflicts with nocache, why not report an error?

Copy link
Contributor Author

@AilinKid AilinKid Jan 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the latter one will take effect

@AilinKid
add more test
8fad35f 
Signed-off-by: ailinkid <314806019@qq.com>
@AilinKid
Merge branch 'master' into fix-31265
2d6dc0d
@AilinKid
.
00d079e 
Signed-off-by: ailinkid <314806019@qq.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 6, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 6, 2022
@djshow832
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1dcef3f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 6, 2022
@AilinKid
Copy link
Contributor Author

AilinKid commented Jan 6, 2022

/merge

@ti-chi-bot ti-chi-bot merged commit bbe4c8e into pingcap:master Jan 6, 2022
@AilinKid AilinKid added affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.1 This bug affects 5.1.x versions. labels Jan 6, 2022
@AilinKid AilinKid added affects-5.0 This bug affects 5.0.x versions. needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Jan 6, 2022
@AilinKid
Copy link
Contributor Author

AilinKid commented Jan 6, 2022

/run-cherry-picker

@ti-srebot ti-srebot mentioned this pull request Jan 6, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #31393

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 6, 2022
@AilinKid @ti-srebot
cherry pick pingcap#31362 to release-5.1
8b1e704 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 6, 2022
@AilinKid @ti-srebot
cherry pick pingcap#31362 to release-5.3
baa0d61 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 6, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #31394

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 6, 2022
@AilinKid @ti-srebot
cherry pick pingcap#31362 to release-5.4
dba7350 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 6, 2022
Merged
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #31395

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 6, 2022
@AilinKid @ti-srebot
cherry pick pingcap#31362 to release-5.2
00b26f3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 6, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #31396

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 6, 2022
@AilinKid @ti-srebot
cherry pick pingcap#31362 to release-5.0
5a7474c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 6, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #31397

ti-chi-bot pushed a commit that referenced this pull request Jan 10, 2022
@ti-srebot
ddl: make sequence cache-opt mutually exclusive to each other (#31362) (
348cabb 
#31395)

close #31265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@djshow832 djshow832 djshow832 approved these changes

Assignees
No one assigned
Labels
affects-5.0 This bug affects 5.0.x versions. affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

alter sequence <sequence> cache <n> does not change sequence cache value which was created as nocache
6 participants
@AilinKid @ti-chi-bot @sre-bot @djshow832 @ti-srebot @hawkingrei