Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: make sure buildHashTable worker exits before IndexHashJoin finish #31334

Merged
merged 9 commits into from
Jan 6, 2022
Merged

executor: make sure buildHashTable worker exits before IndexHashJoin finish #31334

merged 9 commits into from
Jan 6, 2022

Conversation

XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Jan 5, 2022

What problem does this PR solve?

Issue Number: close #31062

Problem Summary:

What is changed and how it works?

Before this commit, buildHashTable worker may be still running while IndexHashJoin has finished already.
This commit makes the Close function wait for buildHashTable worker to exit to fix the problem.

Check List

Tests

Test

Side effects

N/A

Documentation

N/A

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 5, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • guo-shaoge
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 5, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 6, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 6, 2022
@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Jan 6, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3c5f620

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 6, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jan 6, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/7ebf265c2562d55e0dc59d26d3a559c1d5a64c74

@ti-chi-bot ti-chi-bot merged commit 40c0567 into pingcap:master Jan 6, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 6, 2022
@XuHuaiyu @ti-srebot
cherry pick pingcap#31334 to release-5.0
1be00f9 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 6, 2022
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #31416

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 6, 2022
@XuHuaiyu @ti-srebot
cherry pick pingcap#31334 to release-5.1
e3a0b57 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 6, 2022
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #31417

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 6, 2022
@XuHuaiyu @ti-srebot
cherry pick pingcap#31334 to release-5.2
e8d1953 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 6, 2022
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #31418

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 6, 2022
@XuHuaiyu @ti-srebot
cherry pick pingcap#31334 to release-5.3
544cfcd 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 6, 2022
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #31419

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 6, 2022
@XuHuaiyu @ti-srebot
cherry pick pingcap#31334 to release-5.4
d3a70e7 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 6, 2022
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #31420

ti-chi-bot pushed a commit that referenced this pull request Jan 7, 2022
@ti-srebot
executor: make sure buildHashTable worker exits before IndexHashJoin …
9fb7634 
…finish (#31334) (#31420)

close #31062
ti-chi-bot pushed a commit that referenced this pull request Feb 9, 2022
@ti-srebot
executor: make sure buildHashTable worker exits before IndexHashJoin …
269c040 
…finish (#31334) (#31417)

close #31062
ti-chi-bot pushed a commit that referenced this pull request Feb 22, 2022
@ti-srebot
executor: make sure buildHashTable worker exits before IndexHashJoin …
95ad27d 
…finish (#31334) (#31419)

close #31062
ti-chi-bot pushed a commit that referenced this pull request Apr 12, 2022
@ti-srebot
executor: make sure buildHashTable worker exits before IndexHashJoin …
6ce9030 
…finish (#31334) (#31418)

close #31062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@guo-shaoge guo-shaoge guo-shaoge approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/execution SIG execution size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DATA RACE in the ResetContextOfStmt
6 participants
@XuHuaiyu @ti-chi-bot @sre-bot @ti-srebot @guo-shaoge @wshwsh12