-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backup, restore: Write correct api-version in rawkv backup/restore #31122
Conversation
ref #31121 Signed-off-by: Peng Guanwen <pg999w@outlook.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/3f07dedc44d1c7b13f18e665b62fa5eb537a0ebf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
go.mod
Outdated
@@ -103,3 +103,6 @@ replace github.com/pingcap/tidb/parser => ./parser | |||
|
|||
// fix potential security issue(CVE-2020-26160) introduced by indirect dependency. | |||
replace github.com/dgrijalva/jwt-go => github.com/form3tech-oss/jwt-go v3.2.6-0.20210809144907-32ab6a8243d7+incompatible | |||
|
|||
// See https://github.com/pingcap/tidb/pull/31010 | |||
replace github.com/tikv/client-go/v2 => github.com/lemonhx/client-go/v2 v2.0.0-rc.0.20211224062518-60bb3ea439ab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this mean this PR is blocked by #31010?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is blocked by tikv/client-go#405. The root cause of the compilation error is an API breakage introduced in pingcap/kvproto#828. The fix here is copied from #31010.
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
/hold on tikv/client-go#405 |
If #31219 (likely to get merged early than tikv/client-go#405) gets merged, this one will also be unblocked. |
/hold In order to avoid the waste of the CI resource caused by the all test rerun, which is triggered by the merge base operation, I hold this PR, and it can be canceled through the cc: @kennytm @hawkingrei |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 3f07ded
|
/unhold It seems ready to merge. |
Signed-off-by: Peng Guanwen pg999w@outlook.com
What problem does this PR solve?
Issue Number: close #31121
Problem Summary:
BR backup should know the current API version of TiKV and write it in backupmeta.
What is changed and how it works?
Only RawKV backup/restore is changed because TiDB data is compatible across API V1 and V2.
Check List
Tests
Release note