-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: make batch client requests more accurate #30851
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/e41d44d0a661d2262479af299c3743f31e98116e |
7ccbba8
to
a5a1dfe
Compare
/run-monitor-test |
Visit the grafana server at: http://172.16.5.5:30914, it will last for 5 hours |
/run-monitor-test |
Visit the grafana server at: http://172.16.5.5:32229, it will last for 5 hours |
Related to tikv/client-go#397 |
PTAL @bb7133 , thanks! |
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
a5a1dfe
to
48228ef
Compare
/run-monitor-test |
Visit the grafana server at: http://172.16.5.5:32094, it will last for 5 hours |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 48228ef
|
@jackysp: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #31115
Problem Summary:
Because of the mechanism of getting more requests, it is possible for the batch client to get more requests than the max-batch-size, so the original metrics observe position is not very accurate and the upper limit of metrics is too low, only 128.
What is changed and how it works?
fetchMorePendingRequests
.Check List
Tests
Side effects
Documentation
Release note