Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: make batch client requests more accurate #30851

Merged
merged 2 commits into from
Feb 7, 2022

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Dec 18, 2021

What problem does this PR solve?

Issue Number: close #31115

Problem Summary:
Because of the mechanism of getting more requests, it is possible for the batch client to get more requests than the max-batch-size, so the original metrics observe position is not very accurate and the upper limit of metrics is too low, only 128.

What is changed and how it works?

  1. metrics upper limit increase to 1024.
  2. move the metrics observe after fetchMorePendingRequests.
  3. update tidb runtime on Grafana to make it easy to know if there're some pending requests.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. start a cluster
  2. run some workload and check batch client metrics of tidb runtime on Grafana
    image
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 18, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 18, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Dec 18, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@sre-bot
Copy link
Contributor

sre-bot commented Dec 18, 2021

@jackysp jackysp changed the title Batch client metrics metrics: make batch client requests more accurate Dec 19, 2021
@jackysp jackysp force-pushed the batch_client_metrics branch from 7ccbba8 to a5a1dfe Compare December 21, 2021 10:33
@jackysp
Copy link
Member Author

jackysp commented Dec 21, 2021

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented Dec 21, 2021

Visit the grafana server at: http://172.16.5.5:30914, it will last for 5 hours

@jackysp
Copy link
Member Author

jackysp commented Dec 22, 2021

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented Dec 22, 2021

Visit the grafana server at: http://172.16.5.5:32229, it will last for 5 hours

@jackysp
Copy link
Member Author

jackysp commented Dec 22, 2021

Related to tikv/client-go#397

@jackysp
Copy link
Member Author

jackysp commented Jan 15, 2022

PTAL @bb7133 , thanks!

Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@bb7133 bb7133 force-pushed the batch_client_metrics branch from a5a1dfe to 48228ef Compare February 7, 2022 07:33
@wjhuang2016
Copy link
Member

/run-monitor-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 7, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Feb 7, 2022

Visit the grafana server at: http://172.16.5.5:32094, it will last for 5 hours

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 7, 2022
@bb7133
Copy link
Member

bb7133 commented Feb 7, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 48228ef

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 7, 2022
@ti-chi-bot
Copy link
Member

@jackysp: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 4a379b6 into pingcap:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/metrics release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve some metrics on Grafana
5 participants