Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: sequence should always be the one row #30784

Merged
merged 6 commits into from
Dec 28, 2021

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Dec 16, 2021

Signed-off-by: ailinkid 314806019@qq.com

What problem does this PR solve?

Issue Number: close #30786 and #CI test failure

Problem Summary:

[2021-12-16T05:18:24.991Z] ----------------------------------------------------------------------
[2021-12-16T05:18:24.991Z] FAIL: infoschema_reader_test.go:957: testInfoschemaTableSuite.TestSequences
[2021-12-16T05:18:24.991Z] 
[2021-12-16T05:18:24.991Z] infoschema_reader_test.go:966:
[2021-12-16T05:18:24.991Z]     tk.MustQuery("SELECT TABLE_CATALOG, TABLE_SCHEMA, TABLE_NAME , TABLE_TYPE, ENGINE, TABLE_ROWS FROM information_schema.tables WHERE TABLE_TYPE='SEQUENCE' AND TABLE_NAME='seq2'").Check(testkit.Rows("def test seq2 SEQUENCE InnoDB 1"))
[2021-12-16T05:18:24.991Z] /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:67:
[2021-12-16T05:18:24.991Z]     res.c.Assert(resBuff.String(), check.Equals, needBuff.String(), res.comment)
[2021-12-16T05:18:24.991Z] ... obtained string = "[def test seq2 SEQUENCE InnoDB 9]\n"
[2021-12-16T05:18:24.991Z] ... expected string = "[def test seq2 SEQUENCE InnoDB 1]\n"
[2021-12-16T05:18:24.991Z] ... sql:SELECT TABLE_CATALOG, TABLE_SCHEMA, TABLE_NAME , TABLE_TYPE, ENGINE, TABLE_ROWS FROM information_schema.tables WHERE TABLE_TYPE='SEQUENCE' AND TABLE_NAME='seq2', args:[]
[2021-12-16T05:18:24.991Z] 

What is changed and how it works?

sequence count should always be the one row rather than according to the stats info.

Check List

Tests

  • Unit test

Release note

None

Signed-off-by: ailinkid <314806019@qq.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 16, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 16, 2021
@AilinKid AilinKid changed the title schema: sequence always be the one row schema: sequence should always be the one row Dec 16, 2021
@AilinKid AilinKid requested a review from tangenta December 16, 2021 06:46
@tangenta
Copy link
Contributor

Should we disable the statistics on the sequence tables?

@AilinKid
Copy link
Contributor Author

Should we disable the statistics on the sequence tables?

any usage base? maybe we should

@sre-bot
Copy link
Contributor

sre-bot commented Dec 20, 2021

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 28, 2021
Copy link
Member

@hawkingrei hawkingrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 28, 2021
@AilinKid
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cd9fadb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 28, 2021
@ti-chi-bot
Copy link
Member

@AilinKid: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 0af4b77 into pingcap:master Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI test failure with sequence schema row count not equal to one
6 participants