Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: fix init error-manager (#29768) #29804

Merged
merged 2 commits into from
Nov 16, 2021
Merged

lightning: fix init error-manager (#29768) #29804

merged 2 commits into from
Nov 16, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Nov 15, 2021 •
edited by glorv
Loading

cherry-pick #29768 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/29804

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/29804:release-5.3-5992cdab6d10

What problem does this PR solve?

Issue Number: close #29807

Problem Summary:

What is changed and how it works?

Fix the bug this error-manager skip init schemas and tables because a field is not inited.

Check List

Tests

  • Unit test
  • Integration test
    • integration-br-test contains the duplicate detect case
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@glorv @ti-srebot
cherry pick pingcap#29768 to release-5.3
1168d85 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 15, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 15, 2021
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 15, 2021
@ti-srebot ti-srebot mentioned this pull request Nov 15, 2021
Merged
12 tasks
@ti-srebot ti-srebot added component/lightning This issue is related to Lightning of TiDB. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.3-cherry-pick labels Nov 15, 2021
@ti-srebot
Copy link
Contributor Author

@glorv you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 15, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 15, 2021
@glorv
Copy link
Contributor

glorv commented Nov 15, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1168d85

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 15, 2021
@glorv
Copy link
Contributor

glorv commented Nov 15, 2021

/run-integration-br-test

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 15, 2021
@zhouqiang-cl
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@glorv
Copy link
Contributor

glorv commented Nov 15, 2021

/run-check_dev

@glorv
Copy link
Contributor

glorv commented Nov 15, 2021

/run-check_dev

4 similar comments
@glorv
Copy link
Contributor

glorv commented Nov 15, 2021

/run-check_dev

@glorv
Copy link
Contributor

glorv commented Nov 15, 2021

/run-check_dev

@glorv
Copy link
Contributor

glorv commented Nov 15, 2021

/run-check_dev

@glorv
Copy link
Contributor

glorv commented Nov 16, 2021

/run-check_dev

@ti-chi-bot ti-chi-bot merged commit 46bada6 into pingcap:release-5.3 Nov 16, 2021
@glorv glorv deleted the release-5.3-5992cdab6d10 branch November 16, 2021 03:11
@zhouqiang-cl zhouqiang-cl linked an issue Nov 17, 2021 that may be closed by this pull request
release: v4.0.16 #29856
Closed
6 tasks
@zhouqiang-cl zhouqiang-cl removed a link to an issue Nov 17, 2021
release: v4.0.16 #29856
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm approved these changes

@glorv glorv glorv approved these changes

@sleepymole sleepymole Awaiting requested review from sleepymole

Assignees

@glorv glorv

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/lightning This issue is related to Lightning of TiDB. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.3-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-srebot @ti-chi-bot @glorv @zhouqiang-cl @kennytm