Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BR: Git action improvement #29623

Merged
merged 28 commits into from
Nov 11, 2021
Merged

BR: Git action improvement #29623

merged 28 commits into from
Nov 11, 2021

Conversation

fengou1
Copy link
Contributor

@fengou1 fengou1 commented Nov 9, 2021

What problem does this PR solve?

Issue Number: close #29622

Problem Summary:
currently, the runner quota only had 20 runner, those have to run all PR around 158 repo under PingCap. BR Git Action taken 30 minutes for each commit. We remote those redundant compile action, and trigger window compile only PR merged.

What is changed and how it works?

Remove compile under linux familiy kernel, BR only requires go to build project.
So that we remove MAC OS, FreeBSD and Ubuntu, only keep window platform, and only merge PR will trigger the Windows compile action.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 9, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 9, 2021
@fengou1 fengou1 added the component/br This issue is related to BR of TiDB. label Nov 9, 2021
@fengou1 fengou1 added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Nov 9, 2021
@fengou1 fengou1 self-assigned this Nov 9, 2021
@kennytm
Copy link
Contributor

kennytm commented Nov 9, 2021

  • The "Ubuntu" one is actually building against AArch64
  • The FreeBSD one was introduced in FreeBSD support br#1070 because it was found that FreeBSD's types are not exactly compatible with Linux.

These are still valuable. I'd suggest, based on https://github.community/t/trigger-action-via-pull-request-message/17630/4:

  1. change the pull_request trigger to run only when a label was added:

    on:
      push:
        ...
      pull_request:
        types: [labeled]  # <--
        branches:
          ...
  2. make the jobs conditional, only run when the label added is action/run-br-cross-platform-build .

    jobs:
      compile-windows:
        if: github.event_name == 'push' || github.event_name == 'pull_request' && github.event.label.name == 'action/run-br-cross-platform-build'
        ...
      compile-freebsd:
        if: github.event_name == 'pull_request' && github.event.label.name == 'action/run-br-cross-platform-build'
        ...
      compile-linux-aarch64:
        if: github.event_name == 'pull_request' && github.event.label.name == 'action/run-br-cross-platform-build'
        ...
      compile-macos:
        if: github.event_name == 'pull_request' && github.event.label.name == 'action/run-br-cross-platform-build'
        ...

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 10, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 10, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 10, 2021
@3pointer
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 87f0af0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 10, 2021
@fengou1
Copy link
Contributor Author

fengou1 commented Nov 10, 2021

/run-check_dev_2

1 similar comment
@fengou1
Copy link
Contributor Author

fengou1 commented Nov 11, 2021

/run-check_dev_2

@kennytm
Copy link
Contributor

kennytm commented Nov 11, 2021

/merge

@ti-chi-bot
Copy link
Member

@fengou1: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 77f01c3 into pingcap:master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/run-br-cross-platform-build component/br This issue is related to BR of TiDB. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BR: git action improvement
4 participants