Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Remove old syntax ALTER TABLE ... ADD/REMOVE/ALTER PLACEMENT POLICY ... #29603

Merged
merged 5 commits into from
Nov 9, 2021

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #29602

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 9, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • morgo
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 9, 2021
@lcwangchao lcwangchao changed the title *: Remove some syntax with ALTER TABLE ADD/REMOVE/ALTER PLACEMENT *: Remove some syntax with ALTER TABLE ADD/REMOVE/ALTER PLACEMENT POLICY Nov 9, 2021
@lcwangchao lcwangchao changed the title *: Remove some syntax with ALTER TABLE ADD/REMOVE/ALTER PLACEMENT POLICY *: Remove old syntax ALTER TABLE ADD/REMOVE/ALTER PLACEMENT POLICY Nov 9, 2021
@lcwangchao lcwangchao changed the title *: Remove old syntax ALTER TABLE ADD/REMOVE/ALTER PLACEMENT POLICY *: Remove old syntax ALTER TABLE ... ADD/REMOVE/ALTER PLACEMENT POLICY ... Nov 9, 2021
@lcwangchao
Copy link
Collaborator Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 9, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 9, 2021
@morgo
Copy link
Contributor

morgo commented Nov 9, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f3981e8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 9, 2021
@ti-chi-bot
Copy link
Member

@lcwangchao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit dbea989 into pingcap:master Nov 9, 2021
@lcwangchao lcwangchao deleted the remove_alter_placement_spec branch November 10, 2021 06:33
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove old syntax in parser
5 participants