-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br/pkg/lightning: make tidb version check more compitible #29505
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 68bf571
|
/run-check_dev |
2 similar comments
/run-check_dev |
/run-check_dev |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: f418b7f
|
/run-check_dev |
Cherry-pick #29500 to release-5.2
What problem does this PR solve?
TiDB version string can be customized by set the corresponding config field. So parse the result from
select verson()
to get tidb release version is not correct in some case.What is changed and how it works?
select version()
and parse the result as tidb version; If the query returns error, fallback toselect version();
so we can still be compitible with MySQL/MariaDB.Check List
Tests
server-version = 'Test-5.7.22'
), both can detect tidb version correctly and export/import successfullySide effects
Documentation
Release note