-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix the create table with policy will cause the PD failure #29081
Conversation
Signed-off-by: ailinkid <314806019@qq.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix looks correct to me.
clone := rule.Clone() | ||
clone.ID = ruleID | ||
// for the rules of one element id, distinguishing the rule ids to avoid the PD's overlap. | ||
clone.ID = ruleID + "_" + strconv.FormatInt(int64(j), 10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strconv.FormatInt(int64(j), 10)
is actually enough, if you don't mind about the prefixes. Prefixes are useless, IMO, you have RuleIndexTable
anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meaning point is that, once I get the rule, from the name we can get:
1: for which element id it serves
2: which level it's element id stays
3: how many rules for this element id
that's why I built the prefix in the previous pr, convenient for debugging and format output in practice.
/run-all-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: dd08219
|
@AilinKid: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ailinkid 314806019@qq.com
What problem does this PR solve?
Issue Number: close #29006
What is changed and how it works?
Since PD will override the rule with the same ruleID in the one bundle, here we give every rule a distinguished name for one element
Check List
Tests
Release note