Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysqldef: save FSP and fix zone offset for codec #29

Merged
merged 3 commits into from
Sep 7, 2015

Conversation

siddontang
Copy link
Member

hour, min, sec := t.Time.Clock()
nsec := t.Time.Nanosecond()
_, offset := time.Date(year, month, day, hour, min, sec, nsec, time.Local).Zone()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about _, offset := t.Time.In(time.Local).Zone()?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it works

@coocood
Copy link
Member

coocood commented Sep 7, 2015

LGTM

@siddontang siddontang changed the title mysqldef: save FSP and zone offset for codec mysqldef: save FSP and fix zone offset for codec Sep 7, 2015
@qiuyesuifeng
Copy link
Member

LGTM

siddontang added a commit that referenced this pull request Sep 7, 2015
mysqldef: save FSP and fix zone offset for codec
@siddontang siddontang merged commit d628bcb into master Sep 7, 2015
@siddontang siddontang deleted the siddontang/update-time-codec branch September 7, 2015 02:57
YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Apr 23, 2021
* truncate range ts

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* fix downlaod request range

Signed-off-by: 5kbpers <tangminghua@pingcap.com>
okJiang pushed a commit to okJiang/tidb that referenced this pull request Oct 19, 2021
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
Connor1996 pushed a commit to Connor1996/tidb that referenced this pull request Dec 14, 2022
guoshouyan pushed a commit to guoshouyan/tidb that referenced this pull request Mar 5, 2024
… ongoing txn (pingcap#32111) (pingcap#48905) (pingcap#29)

close pingcap#32110

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants