-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infoschema: set TABLES.TABLE_COLLATION null #28807
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
14d2065
to
3fbeecd
Compare
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
3fbeecd
to
5e6e5fa
Compare
/run-check_dev_2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 5e6e5fa
|
@hawkingrei: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: Weizhen Wang wangweizhen@pingcap.com
What problem does this PR solve?
Issue Number: close #27970
Problem Summary:
What is changed and how it works?
What's Changed:
when table_type is
VIEW
,TABLES.TABLE_COLLATION
will be null. butTABLE_COLLATION
is defined as NUT NULL. so fold IsNull function to constant true / false if the expression is marked as NotNull. it will return wrong result.How it Works:
set TABLES.TABLE_COLLATION null.
Check List
Tests
Release note