Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: migrate test-infra to testify for cmsketch_test.go #28552

Merged
merged 9 commits into from
Oct 19, 2021
Merged

statistics: migrate test-infra to testify for cmsketch_test.go #28552

merged 9 commits into from
Oct 19, 2021

Conversation

feitian124
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #28124

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 7, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tisonkun
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 7, 2021
@feitian124
Copy link
Contributor Author

feitian124 commented Oct 7, 2021 •
edited
Loading

ci fails due to

[2021-10-07T02:38:39.053Z] FAIL: db_partition_test.go:2944: testIntegrationSuite5.TestDropSchemaWithPartitionTable
[2021-10-07T02:38:39.053Z] 
[2021-10-07T02:38:39.053Z] db_partition_test.go:2994:
[2021-10-07T02:38:39.053Z]     c.Assert(recordsNum, Equals, 0)
[2021-10-07T02:38:39.053Z] ... obtained int = 4
[2021-10-07T02:38:39.053Z] ... expected int = 0
[2021-10-07T02:38:39.054Z]

https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_check_2/detail/tidb_ghpr_check_2/36958/pipeline

@feitian124
Copy link
Contributor Author

/run-check_dev_2

@feitian124
Copy link
Contributor Author

/cc @tisonkun

@ti-chi-bot ti-chi-bot requested a review from tisonkun October 7, 2021 12:19
tisonkun
tisonkun reviewed Oct 8, 2021
View reviewed changes
statistics/cmsketch_test.go Outdated
c.Assert(err, IsNil)
c.Check(avg, LessEqual, t.avgError)
require.NoError(t, err)
assert.LessOrEqual(t, avg, tt.avgError)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if the original checker call Fail, I tend to use FailNow a.k.a. require always. Unless there is a concrete reason we cannot do that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree with you. updated.

@feitian124
Copy link
Contributor Author

/run-check_dev_2

@feitian124
Copy link
Contributor Author

this should ok, please help review again, thanks @tisonkun

@feitian124
Copy link
Contributor Author

it is pending for some time, could someone help review? thanks.

/cc @tisonkun @winoros @xhebox @tiancaiamao

tisonkun
tisonkun approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution!

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 19, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 19, 2021
@xhebox
Copy link
Contributor

xhebox commented Oct 19, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 51486ff

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 19, 2021
@ti-chi-bot
Copy link
Member

@feitian124: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit c336f95 into pingcap:master Oct 19, 2021
@feitian124 feitian124 mentioned this pull request Oct 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@tisonkun tisonkun tisonkun approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for statistics/cmsketch_test.go
4 participants
@feitian124 @ti-chi-bot @xhebox @tisonkun