Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Add SHOW PLACEMENT support for DB #28366

Merged
merged 7 commits into from
Sep 27, 2021
Merged

*: Add SHOW PLACEMENT support for DB #28366

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
479b636
*: Add `SHOW PLACEMENT` support for DB
lcwangchao Sep 26, 2021
22fc7c0
Merge branch 'master' into show_placement_for_db
lcwangchao Sep 26, 2021
de23326
do some modify
lcwangchao Sep 26, 2021
d6d01c2
Merge branch 'master' into show_placement_for_db
lcwangchao Sep 26, 2021
4c66c5a
Merge branch 'show_placement_for_db' of github.com:lcwangchao/tidb in…
lcwangchao Sep 26, 2021
89d96ed
Merge branch 'master' into show_placement_for_db
ti-chi-bot Sep 27, 2021
83c8054
Merge branch 'master' into show_placement_for_db
ti-chi-bot Sep 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
do some modify
  • Loading branch information
@lcwangchao
lcwangchao committed Sep 26, 2021
commit de23326661407080186cf132bc13efde8a9d99cf
2 changes: 1 addition & 1 deletion executor/show_placement.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ func (e *ShowExec) fetchAllDBPlacements() error {
sort.Slice(dbs, func(i, j int) bool { return dbs[i].Name.O < dbs[j].Name.O })

for _, dbInfo := range dbs {
if e.ctx.GetSessionVars().User != nil && !checker.DBIsVisible(activeRoles, dbInfo.Name.O) {
if e.ctx.GetSessionVars().User != nil && checker != nil && !checker.DBIsVisible(activeRoles, dbInfo.Name.O) {
continue
}

Expand Down