Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: change tidb_top_sql_agent_address to config top-sql.receiver-address #28135

Merged
merged 4 commits into from
Sep 22, 2021
Merged

config: change tidb_top_sql_agent_address to config top-sql.receiver-address #28135

merged 4 commits into from
Sep 22, 2021

Conversation

crazycs520
Copy link
Contributor

…
Signed-off-by: crazycs520 crazycs520@gmail.com

What problem does this PR solve?

In order to easier to enable TopSQL, I change the original instance variable tidb_top_sql_agent_address to the config top-sql.receiver-address. Since it's very inconvenient to connect each TiDB server and set the instance variable.

What is changed and how it works?

  • remove tidb_top_sql_agent_address variable.
  • add top-sql.receiver-address config.

Check List

Tests

  • Unit test

Release note 

None

@crazycs520
config: change tidb_top_sql_agent_address to config top-sql.receiver-…
4173ec4 
…address

Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 17, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breeswish
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 17, 2021
@crazycs520
Copy link
Contributor Author

@breeswish @dragonly PTAL

breezewish
breezewish reviewed Sep 17, 2021
View reviewed changes
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM

@crazycs520
add comment
0c1f50a 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
dragonly
dragonly approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@dragonly dragonly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@dragonly: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 22, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 22, 2021
@crazycs520
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ac07fb3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 22, 2021
@ti-chi-bot ti-chi-bot merged commit c01f1a3 into pingcap:master Sep 22, 2021
@crazycs520 crazycs520 deleted the top-sql-config2 branch September 22, 2021 13:10
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 28, 2021
@crazycs520 @ti-srebot
cherry pick pingcap#28135 to release-5.2
f802ba0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 28, 2021
Merged
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #28453

ti-chi-bot pushed a commit that referenced this pull request Oct 13, 2021
@ti-srebot
config: change tidb_top_sql_agent_address to config top-sql.receiver-…
1ff46a9 
…address (#28135) (#28453)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breezewish breezewish breezewish approved these changes

@dragonly dragonly dragonly approved these changes

@tangenta tangenta tangenta approved these changes

Assignees
No one assigned
Labels
component/config needs-cherry-pick-release-5.2 release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@crazycs520 @ti-chi-bot @ti-srebot @breezewish @dragonly @tangenta