Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflow: backport-x.y.z to fixes-x.y.z #28115

Merged
merged 2 commits into from
Sep 23, 2021
Merged

workflow: backport-x.y.z to fixes-x.y.z #28115

merged 2 commits into from
Sep 23, 2021

Conversation

tisonkun
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #28114

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 17, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • zhouqiang-cl

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 17, 2021
zhouqiang-cl
zhouqiang-cl approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 17, 2021
jebter
jebter approved these changes Sep 17, 2021
View reviewed changes
Copy link

@jebter jebter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@jebter: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tisonkun
Copy link
Contributor Author

/cc @bb7133

Please take a look.

@ti-chi-bot ti-chi-bot requested a review from bb7133 September 21, 2021 11:52
@tisonkun
Copy link
Contributor Author

tisonkun commented Sep 22, 2021 •
edited
Loading

@jebter which labels of fixes-x.y.z should we create?

If we start from now one, we can use all current unreleased version:

  • 3.0.?
  • 4.0.?
  • 5.0.?
  • 5.1.?
  • 5.2.?
  • 5.3.0

@jebter
Copy link

jebter commented Sep 22, 2021 •
edited
Loading

@jebter which labels of fixes-x.y.z should we create?

If we start from now one, we can use all current unreleased version:

  • 3.0.?
  • 4.0.?
  • 5.0.?
  • 5.1.?
  • 5.2.?
  • 5.3.0
  • 4.0.16
  • 5.0.5
  • 5.1.3
  • 5.2.2
  • 5.3.0

@bb7133
Copy link
Member

bb7133 commented Sep 23, 2021

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 23, 2021
@bb7133
Copy link
Member

bb7133 commented Sep 23, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b7cae39

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 23, 2021
@ti-chi-bot
Copy link
Member

@tisonkun: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit e72dc49 into master Sep 23, 2021
@ti-chi-bot ti-chi-bot deleted the tisonkun-patch-2 branch September 23, 2021 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@jebter jebter jebter approved these changes

@zhouqiang-cl zhouqiang-cl zhouqiang-cl approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tag closed bug with fixes-x.y.z instead of backport-x.y.z
5 participants
@tisonkun @ti-chi-bot @jebter @bb7133 @zhouqiang-cl