Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP:types: fix isDateFormat function bugs #27575

Closed
wants to merge 18 commits into from

Conversation

mengxin9014
Copy link
Contributor

@mengxin9014 mengxin9014 commented Aug 25, 2021

What problem does this PR solve?

Issue Number: close #27573

Problem Summary:
fix the bug that a string like "20129" will not be judged as date type
change date_add and date_sub string_(int/string/real/decimal) function return type to string

What is changed and how it works?

Proposal: xxx

What's Changed:
time.go
expression/builtin_time.go
expression/builtin_time_test.go
expression/builtin_time_vec_generated.go
types/time_test.go
cmd/explaintest/r/tpch.result

How it Works:
if the length of a string with no separator is 5, it will be date type
if use date_add or date_sub string_(int/string/real/decimal) function will return string type

Check List

Tests

  • Unit test

Release note

change date_add and date_sub string_(int/string/real/decimal) function return type to string.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 25, 2021
@mengxin9014
Copy link
Contributor Author

/run-all-tests

Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The returning type is wrong.
TiDB:

mysql> select DATE_ADD(a, INTERVAL 1 day ) from t ;
Field   1:  `DATE_ADD(a, INTERVAL 1 day )`
Catalog:    `def`
Database:   ``
Table:      ``
Org_table:  ``
Type:       DATETIME
Collation:  binary (63)
Length:     29
Max_length: 19
Decimals:   31
Flags:      NOT_NULL BINARY


+------------------------------+
| DATE_ADD(a, INTERVAL 1 day ) |
+------------------------------+
| 2020-12-10 00:00:00          |
+------------------------------+
1 row in set (0.00 sec)

MySQL:

mysql> select DATE_ADD(a, INTERVAL 1 day ) from t ;
Field   1:  `DATE_ADD(a, INTERVAL 1 day )`
Catalog:    `def`
Database:   ``
Table:      ``
Org_table:  ``
Type:       STRING
Collation:  utf8mb4_0900_ai_ci (255)
Length:     116
Max_length: 10
Decimals:   31
Flags:


+------------------------------+
| DATE_ADD(a, INTERVAL 1 day ) |
+------------------------------+
| 2020-12-10                   |
+------------------------------+
1 row in set (0.01 sec)

@mengxin9014 mengxin9014 changed the title types: fix isDateFormat function bugs WIP:types: fix isDateFormat function bugs Aug 25, 2021
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2021
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 14, 2021
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 15, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2021
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 16, 2021
@mengxin9014
Copy link
Contributor Author

/run-check_dev_2

@mengxin9014
Copy link
Contributor Author

/run-check_dev_2

3 similar comments
@mengxin9014
Copy link
Contributor Author

/run-check_dev_2

@mengxin9014
Copy link
Contributor Author

/run-check_dev_2

@mengxin9014
Copy link
Contributor Author

/run-check_dev_2

@mengxin9014 mengxin9014 deleted the dev/fixIsDateFormatBug branch September 17, 2021 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dateAdd function bug
4 participants