You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Introduce the sampling by rate by implementing the traditional bernoulli sampling tech.
What is changed and how it works?
Proposal: To be added
What's Changed:
Modify the parser in pingcap/parser#1314 to support the new analyze option.
Modify the tipb in pingcap/tipb#236 to support passing sampling rate to tikv.
We implement the Bernoulli sampling in a very simple way
for each element:
if the rng > sample_rate:
continue
add the current row into the samples.
Check List
Tests
Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code
Side effects
Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility
Documentation
Affects user behaviors
Contains syntax changes
Contains variable changes
Contains experimental features
Changes MySQL compatibility
Release note
Support collecting samples by sampling rate for ANALYZE OPTION
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Details
Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.
ti-chi-bot
added
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Aug 18, 2021
ti-chi-bot
added
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
and removed
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Oct 12, 2021
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
component/statisticsneeds-rebaseIndicates a PR cannot be merged because it has merge conflicts with HEAD.release-noteDenotes a PR that will be considered when it comes time to generate release notes.sig/executionSIG executionsize/XXLDenotes a PR that changes 1000+ lines, ignoring generated files.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #27187, close #26547, for #27357
Problem Summary:
Introduce the sampling by rate by implementing the traditional bernoulli sampling tech.
What is changed and how it works?
Proposal: To be added
What's Changed:
Modify the parser in pingcap/parser#1314 to support the new analyze option.
Modify the tipb in pingcap/tipb#236 to support passing sampling rate to tikv.
We implement the Bernoulli sampling in a very simple way
Check List
Tests
Side effects
Documentation
Release note