Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tablecodec: igrate test-infra to testify #27326

Merged
merged 3 commits into from
Aug 27, 2021

Conversation

jiaxiang521
Copy link
Contributor

@jiaxiang521 jiaxiang521 commented Aug 18, 2021

What problem does this PR solve?

Issue Number: close #26867

What is changed and how it works?

tablecodec:migrate test-infra to testify#26867.

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 18, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • mmyj
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 18, 2021
@CLAassistant
Copy link

CLAassistant commented Aug 18, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 18, 2021
@ti-chi-bot
Copy link
Member

Welcome @jiaxiang521!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

@sre-bot
Copy link
Contributor

sre-bot commented Aug 18, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

1 similar comment
@sre-bot
Copy link
Contributor

sre-bot commented Aug 18, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@jiaxiang521
Copy link
Contributor Author

/cc @tisonkun

@ti-chi-bot ti-chi-bot requested a review from tisonkun August 18, 2021 05:57
@sre-bot
Copy link
Contributor

sre-bot commented Aug 18, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 18, 2021
@jiaxiang521
Copy link
Contributor Author

/run-check_title

@sre-bot
Copy link
Contributor

sre-bot commented Aug 18, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@jiaxiang521
Copy link
Contributor Author

/run-check_title

@sre-bot
Copy link
Contributor

sre-bot commented Aug 18, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@tisonkun tisonkun changed the title tablecodec:migrate test-infra to testify#26867 tablecodec: igrate test-infra to testify Aug 18, 2021
@tisonkun
Copy link
Contributor

@jiaxiang521 there should be a blank between : and the next chapter :(

@tisonkun
Copy link
Contributor

/run-check_title

Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM.

@ti-chi-bot
Copy link
Member

@tisonkun: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Almost LGTM.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tisonkun
Copy link
Contributor

/cc @xhebox @mmyj

@ti-chi-bot
Copy link
Member

@tisonkun: GitHub didn't allow me to request PR reviews from the following users: mmyj.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @xhebox @mmyj

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot requested a review from xhebox August 18, 2021 07:07
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 18, 2021
@tisonkun
Copy link
Contributor

Be aware the next time that "```release-note" the "release-note" part is significant.

@jiaxiang521
Copy link
Contributor Author

Be aware the next time that "```release-note" the "release-note" part is significant.

ok, I will

Copy link
Member

@mmyj mmyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 18, 2021
@ti-chi-bot ti-chi-bot requested a review from xhebox August 23, 2021 13:58
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 26, 2021
@xhebox
Copy link
Contributor

xhebox commented Aug 26, 2021

/cc @mmyj plz help merging

@ti-chi-bot
Copy link
Member

@xhebox: GitHub didn't allow me to request PR reviews from the following users: mmyj, plz, merging.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @mmyj plz help merging

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mmyj
Copy link
Member

mmyj commented Aug 26, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 864226bf1c2b63465dd3f3acccbb4f9e565ffebb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 26, 2021
@mmyj
Copy link
Member

mmyj commented Aug 26, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ tisonkun
✅ ti-chi-bot
✅ jiaxiang521
❌ water521

water521 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tisonkun @jiaxiang521 We need to resolve it?

@tisonkun
Copy link
Contributor

@jiaxiang521 could you please squash commit into one manually? I think it is because you commit with a local user that doesn't sign off CLA and trigger the blocker.

@tisonkun
Copy link
Contributor

or just edit this commit with new author as yourself 328a4dc

@tisonkun
Copy link
Contributor

Well. Let me do it for you...

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed status/can-merge Indicates a PR has been approved by a committer. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 26, 2021
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 26, 2021
@tisonkun
Copy link
Contributor

tisonkun commented Aug 26, 2021

@mmyj I fix the CLA problem. You can check whether the diff is the same as before rebase, and if so, trigger merge again.

@mmyj
Copy link
Member

mmyj commented Aug 26, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 77bbf82

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 26, 2021
@ti-chi-bot ti-chi-bot merged commit 75eb75e into pingcap:master Aug 27, 2021
@jiaxiang521
Copy link
Contributor Author

@jiaxiang521 could you please squash commit into one manually? I think it is because you commit with a local user that doesn't sign off CLA and trigger the blocker.
Sorry, I think it is because i commit with another computer at weekends.

@tisonkun
Copy link
Contributor

@jiaxiang521 never mind. It is done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for tablecodec
7 participants