-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tablecodec: igrate test-infra to testify #27326
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Welcome @jiaxiang521! |
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
1 similar comment
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
/cc @tisonkun |
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
/run-check_title |
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
/run-check_title |
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
@jiaxiang521 there should be a blank between |
/run-check_title |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM.
@tisonkun: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@tisonkun: GitHub didn't allow me to request PR reviews from the following users: mmyj. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Be aware the next time that "```release-note" the "release-note" part is significant. |
ok, I will |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/cc @mmyj plz help merging |
@xhebox: GitHub didn't allow me to request PR reviews from the following users: mmyj, plz, merging. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 864226bf1c2b63465dd3f3acccbb4f9e565ffebb
|
@tisonkun @jiaxiang521 We need to resolve it? |
@jiaxiang521 could you please squash commit into one manually? I think it is because you commit with a local user that doesn't sign off CLA and trigger the blocker. |
or just edit this commit with new author as yourself 328a4dc |
Well. Let me do it for you... |
@mmyj I fix the CLA problem. You can check whether the diff is the same as before rebase, and if so, trigger merge again. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 77bbf82
|
|
@jiaxiang521 never mind. It is done :) |
What problem does this PR solve?
Issue Number: close #26867
What is changed and how it works?
tablecodec:migrate test-infra to testify#26867.
Release note