Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: let tools use the same version detecting mechanism #27060

Merged
merged 15 commits into from
Aug 11, 2021
Merged

br: let tools use the same version detecting mechanism #27060

merged 15 commits into from
Aug 11, 2021

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Aug 10, 2021 •
edited
Loading

What problem does this PR solve?

Problem Summary:

Merge the build environment detect mechanism between TiDB and BR.

Would fix #27095

What is changed and how it works?

What's Changed: TOOLS_LDFLAG has been removed, and BR detect the build context via mysql.TiDBReleaseVersion and package versioninfo.

How it Works: (omitted)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

image

image

- [ ] No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

(For the external viewers, tools should ALWAYS share the same version with TiDB.)

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 10, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2021
@YuJuncen
Copy link
Contributor Author

/label need-cherry-pick-5.2
/sig migrate
/cc 3pointer zwj-coder

@ti-chi-bot ti-chi-bot requested review from 3pointer and ZipFast August 10, 2021 06:53
@ti-chi-bot
Copy link
Member

@YuJuncen: The label(s) need-cherry-pick-5.2 cannot be applied. These labels are supported: CHANGELOG, challenge-program, compatibility-breaker, contribution, correctness, first-time-contributor, good-first-issue, hacktoberfest, high-performance, hptc, need-more-info, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, needs-cherry-pick-5.0, needs-cherry-pick-5.1, proposal, release-note, require-LGT3, security, tools.

In response to this:

/label need-cherry-pick-5.2
/sig migrate
/cc 3pointer zwj-coder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@YuJuncen
Copy link
Contributor Author

/label tools

@ti-chi-bot
Copy link
Member

@YuJuncen: The label(s) tools cannot be applied, because the repository doesn't have them.

In response to this:

/label tools

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@YuJuncen
Copy link
Contributor Author

/label component/tools

(This PR needs to be cherry-picked to release-5.2, or the tools in that branch would detect wrong version (v4.0.0-dev))

@ti-chi-bot
Copy link
Member

@YuJuncen: The label(s) component/tools cannot be applied. These labels are supported: CHANGELOG, challenge-program, compatibility-breaker, contribution, correctness, first-time-contributor, good-first-issue, hacktoberfest, high-performance, hptc, need-more-info, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, needs-cherry-pick-5.0, needs-cherry-pick-5.1, proposal, release-note, require-LGT3, security, tools.

In response to this:

/label component/tools

(This PR needs to be cherry-picked to release-5.2, or the tools in that branch would detect wrong version (v4.0.0-dev))

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@YuJuncen
Copy link
Contributor Author

/label component/tool

@ti-chi-bot
Copy link
Member

@YuJuncen: The label(s) component/tool cannot be applied. These labels are supported: CHANGELOG, challenge-program, compatibility-breaker, contribution, correctness, first-time-contributor, good-first-issue, hacktoberfest, high-performance, hptc, need-more-info, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, needs-cherry-pick-5.0, needs-cherry-pick-5.1, proposal, release-note, require-LGT3, security, tools.

In response to this:

/label component/tool

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@YuJuncen YuJuncen changed the title br: tools uses the same version detecting mechanism br: let tools use the same version detecting mechanism Aug 10, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 11, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 11, 2021
@YuJuncen
Copy link
Contributor Author

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 11, 2021
@YuJuncen
Copy link
Contributor Author

/merge cancel

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 11, 2021
@YuJuncen
Copy link
Contributor Author

/run_unit-test

@YuJuncen
Copy link
Contributor Author

/run-unit-test

1 similar comment
@3pointer
Copy link
Contributor

/run-unit-test

@YuJuncen
Copy link
Contributor Author

/merge cancel

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 11, 2021
@YuJuncen
Copy link
Contributor Author

/run-check_dev

1 similar comment
@YuJuncen
Copy link
Contributor Author

/run-check_dev

@YuJuncen
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 815b774

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 11, 2021
@YuJuncen
Copy link
Contributor Author

/run-build

@YuJuncen
Copy link
Contributor Author

/build

@3pointer
Copy link
Contributor

/rebuild

@3pointer
Copy link
Contributor

/merge

@YuJuncen
Copy link
Contributor Author

/run-unit-test

@YuJuncen
Copy link
Contributor Author

/merge

@YuJuncen
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 760a652 into pingcap:master Aug 11, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 12, 2021
@YuJuncen @ti-srebot
cherry pick pingcap#27060 to release-5.2
9a8d49c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 12, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #27145

ti-chi-bot pushed a commit that referenced this pull request Aug 13, 2021
@ti-srebot
br: let tools use the same version detecting mechanism (#27060) (#27145)
4c68def
joccau pushed a commit to joccau/tidb that referenced this pull request Sep 7, 2021
@YuJuncen
br: let tools use the same version detecting mechanism (pingcap#27060)
38228bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3pointer 3pointer 3pointer approved these changes

@glorv glorv glorv approved these changes

@ZipFast ZipFast Awaiting requested review from ZipFast

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.2 release-note-none Denotes a PR that doesn't merit a release note. sig/migrate size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lightning tidb version precheck failed
6 participants
@YuJuncen @ti-chi-bot @3pointer @ti-srebot @glorv @jebter