Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: Support push InetAton, InetNtoa, Inet6Aton, and Inet6Nota down to TiFlash #26984

Merged
merged 4 commits into from
Aug 7, 2021
Merged

expression: Support push InetAton, InetNtoa, Inet6Aton, and Inet6Nota down to TiFlash #26984

merged 4 commits into from
Aug 7, 2021

Conversation

fuzhe1989
Copy link
Contributor

@fuzhe1989 fuzhe1989 commented Aug 7, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: pingcap/tiflash#2427

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

Support push InetAton, InetNtoa, Inet6Aton, and Inet6Nota down to TiFlash

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 7, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 7, 2021
@fuzhe1989
Copy link
Contributor Author

/run-check-dev

@fuzhe1989
Copy link
Contributor Author

/cc @zanmato1984 @LittleFall

LittleFall
LittleFall approved these changes Aug 7, 2021
View reviewed changes
Copy link
Contributor

@LittleFall LittleFall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 7, 2021
@fuzhe1989
Copy link
Contributor Author

/run-check_dev_2

@fuzhe1989
Copy link
Contributor Author

/cc @leiysky

@ti-chi-bot
Copy link
Member

@fuzhe1989: GitHub didn't allow me to request PR reviews from the following users: leiysky.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @leiysky

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zanmato1984
zanmato1984 approved these changes Aug 7, 2021
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 7, 2021
@zanmato1984
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 209038a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 7, 2021
@ti-chi-bot ti-chi-bot merged commit 8e0b570 into pingcap:master Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@LittleFall LittleFall LittleFall approved these changes

Assignees
No one assigned
Labels
component/expression release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fuzhe1989 @ti-chi-bot @zanmato1984 @LittleFall