*: update client-go to solve #26359 #26650
Conversation
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
ti-chi-bot
added
release-note
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 2afd784
|
ti-chi-bot
added
the
status/can-merge
|
/run-all-tests |
|
/merge |
|
@zhouqiang-cl: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
ti-chi-bot
removed
the
status/can-merge
|
/run-all-tests |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 29e9940
|
ti-chi-bot
added
the
status/can-merge
|
@sticnarf: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
| @@ -57,8 +57,6 @@ func TestPreview(t *testing.T) { | |||
| t.Skip("integration.NewClusterV3 will create file contains a colon which is not allowed on Windows") | |||
| } | |||
|
|
|||
| t.Parallel() | |||
There was a problem hiding this comment.
@sticnarf could you explain why these tests cannot run in parallel now?
There was a problem hiding this comment.
I see the commit message said "data race”, but how?
There was a problem hiding this comment.
These tests modify config.GetGlobalConfig().EnableTelemetry. Other tests may read this config.
What problem does this PR solve?
Issue Number: close #26359 on master
What is changed and how it works?
Update client-go to include tikv/client-go#244.
This sets the retry flag in
Contextso TiKV will check if the prewrite has been sent before and avoid making the result not idempotent.See tikv/tikv#10600 for detail.
Check List
Tests
Release note