Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: the UNION's merge type should exclude the pure NULL #26561

Merged
merged 2 commits into from
Jul 26, 2021
Merged

planner: the UNION's merge type should exclude the pure NULL #26561

merged 2 commits into from
Jul 26, 2021

Conversation

winoros
Copy link
Member

@winoros winoros commented Jul 26, 2021

What problem does this PR solve?

Issue Number: close #26559

Problem Summary:

When there are pure NULL values in the child query, TiDB would get the wrong length of some field types, causing the wrong return results.

What is changed and how it works?

Proposal: xxx

What's Changed:

When merging the field types of the children, we ignore the pure NULLs.

Check List

Tests

  • Unit test

Release note

  • Fix the case that TiDB would return the wrong result when the children of the UNION contain pure NULL values

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 26, 2021
XuHuaiyu
XuHuaiyu approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 26, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 26, 2021
@ichn-hu ichn-hu mentioned this pull request Jul 26, 2021
Closed
@winoros
Copy link
Member Author

winoros commented Jul 26, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4d899d8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 26, 2021
@ti-chi-bot ti-chi-bot merged commit 71638ee into pingcap:master Jul 26, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 26, 2021
@winoros @ti-srebot
cherry pick pingcap#26561 to release-4.0
2f423fa 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 26, 2021
Merged
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #26570

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 26, 2021
@winoros @ti-srebot
cherry pick pingcap#26561 to release-5.0
02fd19a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 26, 2021
Merged
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #26571

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 26, 2021
@winoros @ti-srebot
cherry pick pingcap#26561 to release-5.1
930f6a0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 26, 2021
Merged
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #26572

@winoros winoros deleted the issue26559 branch July 26, 2021 09:52
ti-chi-bot pushed a commit that referenced this pull request Jul 26, 2021
@ti-srebot
planner: the UNION's merge type should exclude the pure NULL (#26561) (…
4f919b0 
…#26570)
ti-chi-bot pushed a commit that referenced this pull request Jul 26, 2021
@ti-srebot
planner: the UNION's merge type should exclude the pure NULL (#26561) (…
48c4b91 
…#26571)
ti-chi-bot pushed a commit that referenced this pull request Jul 26, 2021
@ti-srebot
planner: the UNION's merge type should exclude the pure NULL (#26561) (…
168aab5 
…#26572)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uncorrect result when there's union
5 participants
@winoros @ti-chi-bot @ti-srebot @qw4990 @XuHuaiyu