*: Support the statement of ALTER [COLUMN] col_name SET DEFAULT
#2608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coocood
reviewed
Feb 7, 2017
| @@ -880,6 +880,17 @@ AlterTableSpec: | |||
| NewColumn: $4.(*ast.ColumnDef), | |||
| } | |||
| } | |||
| | "ALTER" "COLUMN" ColumnName "SET" "DEFAULT" SignedLiteral | |||
| { | |||
| option := &ast.ColumnOption{Expr: $6.(ast.ExprNode)} | |||
There was a problem hiding this comment.
We can use original type information.
coocood
reviewed
Feb 7, 2017
| // Check column default value. | ||
| // TODO: Put this code to checkDefaultValue and fix issue 2600. | ||
| colInfo := col.ToInfo() | ||
| _, _, err = table.GetColDefaultValue(ctx, colInfo) |
There was a problem hiding this comment.
Why try to get default value here?
There was a problem hiding this comment.
It uses to check column default value as the comment say.
|
LGTM |
|
PTAL @coocood |
|
LGTM |
coocood
approved these changes
Feb 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2383