Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl/model: fix redundant query prints in ddl log #2599

Merged
merged 1 commit into from
Feb 7, 2017
Merged

ddl/model: fix redundant query prints in ddl log #2599

merged 1 commit into from
Feb 7, 2017

Conversation

andelf
Copy link
Contributor

@andelf andelf commented Feb 6, 2017

This fixes:

2017/02/06 16:59:08 ddl.go:319: [info] [ddl] start DDL job ID:20, Type:create schema, State:none, SchemaState:none, SchemaID:19, TableID:0, RowCount:0, ArgLen:1, Query:
create database sbtest
2017/02/06 16:59:08 ddl_worker.go:336: [info] [ddl] run DDL job ID:20, Type:create schema, State:none, SchemaState:none, SchemaID:19, TableID:0, RowCount:0, ArgLen:0, Query:
create database sbtest
2017/02/06 16:59:08 ddl_worker.go:184: [info] [ddl] finish DDL job ID:20, Type:create schema, State:done, SchemaState:public, SchemaID:19, TableID:0, RowCount:0, ArgLen:1, Query:
create database sbtest

Now:

2017/02/06 16:59:08 ddl.go:319: [info] [ddl] start DDL job ID:20, Type:create schema, State:none, SchemaState:none, SchemaID:19, TableID:0, RowCount:0, ArgLen:1, Query:
create database sbtest
2017/02/06 16:59:08 ddl_worker.go:336: [info] [ddl] run DDL job ID:20, Type:create schema, State:none, SchemaState:none, SchemaID:19, TableID:0, RowCount:0, ArgLen:0
2017/02/06 16:59:08 ddl_worker.go:184: [info] [ddl] finish DDL job ID:20, Type:create schema, State:done, SchemaState:public, SchemaID:19, TableID:0, RowCount:0, ArgLen:1

@ngaut
Copy link
Member

ngaut commented Feb 7, 2017

LGTM

coocood
coocood approved these changes Feb 7, 2017
View reviewed changes
Copy link
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood coocood merged commit 76bf890 into pingcap:master Feb 7, 2017
@andelf andelf deleted the fix-ddl-log-format branch February 7, 2017 04:48
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coocood coocood coocood approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andelf @ngaut @coocood @sre-bot