Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: force tidb_multi_statement_mode=OFF when mode=WARN (#25723) #25751

Merged
merged 2 commits into from
Jul 5, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jun 24, 2021

cherry-pick #25723 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/25751

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/25751:release-5.1-1cab530b793a

What problem does this PR solve?

Problem Summary:

In TiDB 5.0 the default for tidb_multi_statement_mode=OFF, but for upgrades the previous default from 4.0 could be inherited. This changes the value for upgrades as well.

From the docs, "Only the default value of OFF can be considered safe". This was always known to be the case, WARN was introduced to provide a nagging upgrade path for users. Now its time.

What is changed and how it works?

What's Changed:

For users upgrading from TiDB 4.0, the value of tidb_multi_statement_mode is now OFF. It is recommended to use the multi-statement feature of your client library instead, see the documentation on tidb_multi_statement_mode for additional details.

Related changes

  • Need to cherry-pick to the release branch
  • The cherry pick to 4.0 will look a bit different as it also needs to change the sysvar default.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Bootstrap tasks are hard to test with automated testing. I launched a 4.0.13 server and then ran the SQL statement in this bootstrap task and confirmed only 1 row was modified, and the value changed to OFF.

Side effects

  • Breaking backward compatibility

Release note

  • For users upgrading from TiDB 4.0, the value of tidb_multi_statement_mode is now OFF. It is recommended to use the multi-statement feature of your client library instead, see the documentation on tidb_multi_statement_mode for additional details.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.1-cherry-pick labels Jun 24, 2021
@ti-srebot ti-srebot requested review from bb7133 and xhebox June 24, 2021 12:33
@ti-srebot
Copy link
Contributor Author

@morgo please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/tidb/invitations

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 25, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 1, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 1, 2021
@bb7133
Copy link
Member

bb7133 commented Jul 1, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a4708b9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 1, 2021
@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@morgo
Copy link
Contributor

morgo commented Jul 5, 2021

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit e6c94d9 into pingcap:release-5.1 Jul 5, 2021
@zhouqiang-cl zhouqiang-cl added this to the v5.1.1 milestone Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.1-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants