-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session: force tidb_multi_statement_mode=OFF when mode=WARN (#25723) #25751
session: force tidb_multi_statement_mode=OFF when mode=WARN (#25723) #25751
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
@morgo please accept the invitation then you can push to the cherry-pick pull requests. |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: a4708b9
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-unit-test |
cherry-pick #25723 to release-5.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/25751
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Problem Summary:
In TiDB 5.0 the default for
tidb_multi_statement_mode=OFF
, but for upgrades the previous default from 4.0 could be inherited. This changes the value for upgrades as well.From the docs, "Only the default value of OFF can be considered safe". This was always known to be the case,
WARN
was introduced to provide a nagging upgrade path for users. Now its time.What is changed and how it works?
What's Changed:
For users upgrading from TiDB 4.0, the value of
tidb_multi_statement_mode
is nowOFF
. It is recommended to use the multi-statement feature of your client library instead, see the documentation ontidb_multi_statement_mode
for additional details.Related changes
Check List
Tests
Bootstrap tasks are hard to test with automated testing. I launched a 4.0.13 server and then ran the SQL statement in this bootstrap task and confirmed only 1 row was modified, and the value changed to
OFF
.Side effects
Release note
tidb_multi_statement_mode
is nowOFF
. It is recommended to use the multi-statement feature of your client library instead, see the documentation ontidb_multi_statement_mode
for additional details.