Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linter: fix linter error when make dev locally #25661

Merged
merged 6 commits into from
Jun 23, 2021
Merged

linter: fix linter error when make dev locally #25661

merged 6 commits into from
Jun 23, 2021

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Jun 22, 2021 •
edited
Loading

What problem does this PR solve?

fix some errors below

planner/core/preprocess.go:132:2: `initedLastSnapshotTS` is unused (structcheck)
        initedLastSnapshotTS bool
        ^
server/tidb_test.go:1496:2: ineffectual assignment to `cancel` (ineffassign)
        cancel = cancel = runWorkload(0, 10)
        ^
server/tidb_test.go:1513:2: ineffectual assignment to `cancel` (ineffassign)
        cancel = cancel = runWorkload(0, 10)
        ^
server/tidb_test.go:1515:2: ineffectual assignment to `cancel` (ineffassign)
        cancel = runWorkload(11, 20)
        ^
structure/type.go:51:23: func `(*TxStructure).encodeHashMetaKey` is unused (unused)

What is changed and how it works?

How it Works: make usage of some variable to make linter happy

Check List

Tests

  • Unit test
  • Integration test

Release note

  • linter: fix linter error when make dev locally

AilinKid added 2 commits June 22, 2021 16:50
@AilinKid
make linter happy locally
e587e00 
Signed-off-by: ailinkid <314806019@qq.com>
@AilinKid
.
ab9d829 
Signed-off-by: ailinkid <314806019@qq.com>
@AilinKid AilinKid requested review from a team as code owners June 22, 2021 08:52
@AilinKid AilinKid requested review from wshwsh12 and XuHuaiyu and removed request for a team June 22, 2021 08:52
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 22, 2021
@AilinKid AilinKid requested review from crazycs520 and zimulala and removed request for wshwsh12 and XuHuaiyu June 22, 2021 08:54
@github-actions github-actions bot added sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels Jun 22, 2021
AilinKid added 2 commits June 22, 2021 17:24
@AilinKid
use diff variable
531028c 
Signed-off-by: ailinkid <314806019@qq.com>
@AilinKid
Merge branch 'master' into fix-linter
b0e76a0
@AilinKid
Copy link
Contributor Author

/run-check_dev

crazycs520
crazycs520 approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 22, 2021
zimulala
zimulala approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • crazycs520
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 23, 2021
@zimulala
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4730e06

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 23, 2021
@AilinKid
Copy link
Contributor Author

/run-check_dev

@AilinKid
Copy link
Contributor Author

/build

@AilinKid
Copy link
Contributor Author

/rebuild

@AilinKid AilinKid closed this Jun 23, 2021
@AilinKid AilinKid reopened this Jun 23, 2021
@ti-chi-bot ti-chi-bot merged commit 8c33190 into pingcap:master Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

Assignees
No one assigned
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AilinKid @ti-chi-bot @zimulala @crazycs520