Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: select distinct should bypass batchget #25477

Merged
merged 2 commits into from
Jun 17, 2021
Merged

planner: select distinct should bypass batchget #25477

merged 2 commits into from
Jun 17, 2021

Conversation

zhuo-zhi
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #25320

Problem Summary:

  • Query with distinct gets wrong result

What is changed and how it works?

What's Changed:

  • func tryWhereIn2BatchPointGet

How it Works:

  • do not generate batchget plan if distinct is in the statement.

Check List

Tests

  • Unit test

Side effects

  • N/A

Release note

  • planner: select distinct should bypass batchget

@zhuo-zhi zhuo-zhi requested review from a team as code owners June 16, 2021 07:45
@zhuo-zhi zhuo-zhi requested review from wshwsh12 and winoros and removed request for a team June 16, 2021 07:45
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 16, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Jun 16, 2021
@ichn-hu ichn-hu mentioned this pull request Jun 16, 2021
Closed
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 17, 2021
@ti-chi-bot
Copy link
Member

@xiongjiwei: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qw4990
Copy link
Contributor

qw4990 commented Jun 17, 2021

/merge

@ti-chi-bot
Copy link
Member

@qw4990: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 17, 2021
@qw4990
Copy link
Contributor

qw4990 commented Jun 17, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1cb9ccb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 17, 2021
@zhouqiang-cl
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@zhouqiang-cl: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit ba77a2f into pingcap:master Jun 17, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 17, 2021
@zhuo-zhi @ti-srebot
cherry pick pingcap#25477 to release-4.0
f0b7e90 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 17, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #25532

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 17, 2021
@zhuo-zhi @ti-srebot
cherry pick pingcap#25477 to release-5.0
1265b35 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 17, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #25533

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 17, 2021
@zhuo-zhi @ti-srebot
cherry pick pingcap#25477 to release-5.1
2c68784 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 17, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #25534

zhouqiang-cl pushed a commit that referenced this pull request Jun 18, 2021
@ti-srebot
cherry pick #25477 to release-5.1 (#25534)
727fd95 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-chi-bot pushed a commit that referenced this pull request Jun 22, 2021
@ti-srebot
planner: select distinct should bypass batchget (#25477) (#25533)
660bace
ti-chi-bot pushed a commit that referenced this pull request Jul 7, 2021
@ti-srebot
planner: select distinct should bypass batchget (#25477) (#25532)
06df314
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@xiongjiwei xiongjiwei xiongjiwei approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 sig/execution SIG execution size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query with distinct got wrong result
7 participants
@zhuo-zhi @ti-chi-bot @qw4990 @zhouqiang-cl @ti-srebot @wjhuang2016 @xiongjiwei