store/tikv: refine the retry mechanism of region errors #25165
Conversation
ti-chi-bot
added
the
size/L
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
youjiali1995
force-pushed
the
improve-region-error-handling
branch
from
cf384c8 to
fdf5875
Compare
| @@ -89,6 +89,7 @@ var ( | |||
| BoPDRPC = NewConfig("pdRPC", &metrics.BackoffHistogramPD, NewBackoffFnCfg(500, 3000, EqualJitter), tikverr.NewErrPDServerTimeout("")) | |||
| // change base time to 2ms, because it may recover soon. | |||
| BoRegionMiss = NewConfig("regionMiss", &metrics.BackoffHistogramRegionMiss, NewBackoffFnCfg(2, 500, NoJitter), tikverr.ErrRegionUnavailable) | |||
| BoRegionScheduling = NewConfig("regionScheduling", &metrics.BackoffHistogramRegionScheduling, NewBackoffFnCfg(2, 500, NoJitter), tikverr.ErrRegionUnavailable) | |||
There was a problem hiding this comment.
Add the
regionSchedulingbackoff configuration for backoff due to region scheduling which is separated from theregionMiss. The aim is to reduce backoff sleep time.
BoRegionScheduling config is the same as BoRegionMiss?
There was a problem hiding this comment.
Yes. It reduces the backoff sleep time by dividing the backoff times to different configs.
| @@ -939,6 +947,7 @@ func (s *RegionRequestSender) onRegionError(bo *Backoffer, ctx *RPCContext, req | |||
| } | |||
| return retry, errors.Trace(err) | |||
| } | |||
|
|
|||
| if regionErr.GetServerIsBusy() != nil { | |||
| logutil.BgLogger().Warn("tikv reports `ServerIsBusy` retry later", | |||
There was a problem hiding this comment.
Should the log level be adjusted like others?
There was a problem hiding this comment.
I think it's qualified...
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: d89d38c
|
ti-chi-bot
added
the
status/can-merge
|
@youjiali1995: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: youjiali1995 zlwgx1023@gmail.com
What problem does this PR solve?
Problem Summary:
TiKV adds more region errors, e.g.,
ReadIndexNotReady/ProposalInMergingMode/DataIsNotReady/RegionNotInitialized, TiDB should handle them properly.What is changed and how it works?
What's Changed:
regionSchedulingbackoff configuration for backoff due to region scheduling which is separated from theregionMiss. The aim is to reduce backoff sleep time.Related changes
Check List
Tests
Side effects
Release note