Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: Support push function year,day,datediff,datesub,castTimeAsString,concat_ws down to TiFlash. (#25097) #25145

Closed
wants to merge 1 commit into from
Closed

expression: Support push function year,day,datediff,datesub,castTimeAsString,concat_ws down to TiFlash. (#25097) #25145

wants to merge 1 commit into from

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jun 4, 2021 •
edited
Loading

cherry-pick #25097 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/25145

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/25145:release-5.0-6154335ac017

What problem does this PR solve?

Issue Number: close pingcap/tiflash#1480

Problem Summary: Support push fucntion year,day,datediff,datesub,castTimeAsString down to TiFlash.

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch: no need

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Support push fucntion year,day,datediff,datesub(datetime sub int, string sub int),castTimeAsString and concat_ws down to TiFlash.

@LittleFall @ti-srebot
cherry pick pingcap#25097 to release-5.0
ae3e967 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot requested a review from a team as a code owner June 4, 2021 06:36
@ti-srebot ti-srebot requested review from qw4990 and removed request for a team June 4, 2021 06:36
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added component/expression size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.0-cherry-pick labels Jun 4, 2021
@ti-srebot ti-srebot mentioned this pull request Jun 4, 2021
Merged
@ti-srebot ti-srebot added this to the v5.0.2 milestone Jun 4, 2021
@ti-srebot
Copy link
Contributor Author

@LittleFall you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 4, 2021
leiysky
leiysky reviewed Jun 17, 2021
View reviewed changes
expression/expr_to_pb_test.go
@@ -724,6 +724,109 @@ func (s *testEvaluatorSuite) TestExprPushDownToFlash(c *C) {
c.Assert(err, IsNil)
exprs = append(exprs, function)

<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should fix conflict

@leiysky leiysky mentioned this pull request Jun 17, 2021
Closed
@ti-chi-bot
Copy link
Member

@ti-srebot: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2021
@LittleFall
Copy link
Contributor

should be closed by #25564

@lzmhhh123
Copy link
Contributor

Already cherry-picked.

@lzmhhh123 lzmhhh123 closed this Jun 18, 2021
@LittleFall LittleFall deleted the release-5.0-6154335ac017 branch June 18, 2021 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leiysky leiysky leiysky left review comments

@qw4990 qw4990 Awaiting requested review from qw4990

@jackysp jackysp Awaiting requested review from jackysp

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

@windtalker windtalker Awaiting requested review from windtalker

Assignees

@LittleFall LittleFall

Labels
component/expression do-not-merge/cherry-pick-not-approved needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/5.0-cherry-pick
Projects
None yet
Milestone
v5.0.2
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-srebot @ti-chi-bot @LittleFall @lzmhhh123 @leiysky