Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/tikv: add and fix some metrics for the new retry logic #25123

Merged
merged 28 commits into from
Jun 7, 2021
Merged

store/tikv: add and fix some metrics for the new retry logic #25123

merged 28 commits into from
Jun 7, 2021

Conversation

sticnarf
Copy link
Contributor

@sticnarf sticnarf commented Jun 4, 2021

What is changed and how it works?

The exit cause of the replica selector is recorded in the metrics. The retry time of a request is recorded in a histogram.

The commit backoff time is improved. Because prewrite is mostly parallel, we only record the max total sleep of all backoffs in prerwite. (But this is not the real time spent on prewrite because of the concurrency limit.)

The backoff time of the commit phase is not counted in the batch executor. commitTxn adds the time to the final commit backoff time.

Check List

Tests

  • No code

Release note

  • No release note

@sticnarf
store/tikv: add and fix some metrics for the new retry logic
c513407 
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
@sticnarf sticnarf added the sig/transaction SIG:Transaction label Jun 4, 2021
@sticnarf sticnarf requested a review from youjiali1995 June 4, 2021 02:07
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 4, 2021
@sticnarf sticnarf requested a review from a team as a code owner June 4, 2021 02:14
@sticnarf sticnarf requested review from lzmhhh123 and removed request for a team June 4, 2021 02:14
@sticnarf sticnarf force-pushed the new-retry-metrics branch from 6318331 to ce21836 Compare June 4, 2021 02:17
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 4, 2021
@sticnarf sticnarf force-pushed the new-retry-metrics branch from ce21836 to 17cffa6 Compare June 4, 2021 02:22
@sticnarf
fix build
81eb9d6 
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
@sticnarf sticnarf force-pushed the new-retry-metrics branch from 17cffa6 to 81eb9d6 Compare June 4, 2021 03:13
sticnarf
sticnarf commented Jun 4, 2021
View reviewed changes
store/tikv/2pc.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added the sig/execution SIG execution label Jun 4, 2021
@youjiali1995 youjiali1995 requested a review from lysu June 4, 2021 05:58
youjiali1995
youjiali1995 reviewed Jun 4, 2021
View reviewed changes
store/tikv/2pc.go Outdated Show resolved Hide resolved
store/tikv/2pc.go Show resolved Hide resolved
youjiali1995
youjiali1995 reviewed Jun 4, 2021
View reviewed changes
Copy link
Contributor

@youjiali1995 youjiali1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding metrics for commitDetail? i.e., backoff time and count of a single transaction commit.

lysu
lysu reviewed Jun 4, 2021
View reviewed changes
store/tikv/2pc.go Show resolved Hide resolved
@sticnarf
avoid adding duplicate backoff types
bbfa461 
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
lysu
lysu reviewed Jun 4, 2021
View reviewed changes
store/tikv/2pc.go
boSleep := int64(singleBatchBackoffer.GetTotalSleep()) * int64(time.Millisecond)
if boSleep > commitDetail.Mu.CommitBackoffTime {
commitDetail.Mu.CommitBackoffTime = boSleep
commitDetail.Mu.BackoffTypes = singleBatchBackoffer.GetTypes()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need

commitDetail.Mu.BackoffTypes = append(batchExe.backoffer.GetTypes(), singleBatchBackoffer.GetTypes()...)

clone seems not inherit parent's backoff types

Copy link
Contributor Author

@sticnarf sticnarf Jun 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I thought the backoff types are inherited... It looks difficult to handle the backoff types T_T

sticnarf added 5 commits June 4, 2021 17:10
@sticnarf
add metrics about commitDetail
14bc798 
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
@sticnarf
get backoffs including its parent
4af5b2e 
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
@sticnarf
Merge branch 'master' into new-retry-metrics
c17363d
@sticnarf
let backoff.Clone clone its parent
f6b8641 
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
@sticnarf
Merge branch 'new-retry-metrics' of github.com:sticnarf/tidb into new…
a6fe337 
…-retry-metrics
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 4, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lysu
  • youjiali1995

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@youjiali1995
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5774f5f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 7, 2021
@sticnarf
Copy link
Contributor Author

sticnarf commented Jun 7, 2021

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented Jun 7, 2021

Visit the grafana server at: http://172.16.5.5:30721, it will last for 5 hours

sticnarf added 2 commits June 7, 2021 16:05
@sticnarf
fix datasource
649b0ab 
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
@sticnarf
Merge branch 'new-retry-metrics' of github.com:sticnarf/tidb into new…
2c65e23 
…-retry-metrics
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 7, 2021
@sticnarf
Copy link
Contributor Author

sticnarf commented Jun 7, 2021

/run-monitor-test

@sticnarf sticnarf closed this Jun 7, 2021
@sticnarf sticnarf reopened this Jun 7, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Jun 7, 2021

Visit the grafana server at: http://172.16.5.5:32362, it will last for 5 hours

@sticnarf
Copy link
Contributor Author

sticnarf commented Jun 7, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2c65e23

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 7, 2021
@ti-chi-bot ti-chi-bot merged commit 840494d into pingcap:master Jun 7, 2021
@sticnarf
Copy link
Contributor Author

sticnarf commented Jun 7, 2021

/run-cherry-picker

@ti-srebot ti-srebot mentioned this pull request Jun 7, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #25212

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 7, 2021
@sticnarf @ti-srebot
cherry pick pingcap#25123 to release-5.1
29b437c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-chi-bot pushed a commit that referenced this pull request Jun 9, 2021
@ti-srebot
store/tikv: add and fix some metrics for the new retry logic (#25123) (…
39ce37f 
…#25212)
@sticnarf sticnarf mentioned this pull request Nov 3, 2021
Merged
13 tasks
This was referenced Nov 23, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youjiali1995 youjiali1995 youjiali1995 approved these changes

@lysu lysu lysu approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.1 sig/execution SIG execution sig/transaction SIG:Transaction size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sticnarf @ti-chi-bot @youjiali1995 @lysu @bb7133 @sre-bot @ti-srebot