-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store/tikv: clear undetermined error if txn determines to fail #25120
Conversation
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest lgtm.
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 3d8253a
|
@sticnarf: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
pingcap#25120)" This reverts commit 5a74d52.
What problem does this PR solve?
After #25040, if there is a determined error in a inner recursion and there is an RPC error in the parent, it is still possible that a transaction that is determined to fail reports an undetermined error.
What is changed and how it works?
Set a flag if a transaction is determined to fail after receiving an error prewrite response. Then, if the flag exists, we can ignore the undetermined error.
Check List
Tests
Release note
No release note