-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix ifnull bug when arg is enum/set #25110
Conversation
Signed-off-by: guo-shaoge <shaoge1994@163.com>
/cc @wshwsh12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 6697d5e
|
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.0 in PR #25116 |
/run-cherry-picker |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #26035 |
Signed-off-by: guo-shaoge shaoge1994@163.com
What problem does this PR solve?
Issue Number: close #24944
Problem Summary: Just as this comment said.
ifnull
will be removed if its first argument has not null attributes. But it doesn't work properly if first argument is enum/set. Because enum/set has two semantics(int/string). We may use its string semantics unexpectedly. So we cannot remoteifnull
if its first argument is enum/set.What is changed and how it works?
What's Changed: If
ifnull
's first argument is enum/set, doesn't rewrite it.Related changes
Check List
Tests
Side effects: We may lose some performance for
ifnull
expression when argument is enum/set. But we have to do it to make it right.Release note