Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Remove incorrect global sysvar caching #24699

Merged
merged 8 commits into from
May 25, 2021

Conversation

morgo
Copy link
Contributor

@morgo morgo commented May 17, 2021

What problem does this PR solve?

Issue Number: close #24368

Problem Summary:

What is changed and how it works?

What's Changed:

Previously running SHOW VARIABLES would cache global-only sysvars, which was an incorrect behavior. The values are now no longer cached.

Related changes

Check List

Tests

  • Integration test

Side effects

  • None

Release note

  • Previously the value of global-only system variables may have been cached in a session. TiDB now no longer caches these values in the session, which is a more-compatible behavior with MySQL.

@morgo morgo requested review from a team as code owners May 17, 2021 15:23
@morgo morgo requested review from XuHuaiyu and removed request for a team May 17, 2021 15:23
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 17, 2021
@morgo morgo added the sig/sql-infra SIG: SQL Infra label May 17, 2021
@morgo morgo requested a review from a team May 17, 2021 15:26
@morgo
Copy link
Contributor Author

morgo commented May 17, 2021

/run-all-tests

1 similar comment
@zhouqiang-cl
Copy link
Contributor

/run-all-tests

@xhebox
Copy link
Contributor

xhebox commented May 19, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 19, 2021
@morgo morgo requested a review from tiancaiamao May 24, 2021 04:55
@wjhuang2016
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • wjhuang2016
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 25, 2021
@morgo
Copy link
Contributor Author

morgo commented May 25, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2adab1a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 25, 2021
@ti-chi-bot
Copy link
Member

@morgo: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@morgo
Copy link
Contributor Author

morgo commented May 25, 2021

/run-integration-common-test

@ti-chi-bot ti-chi-bot merged commit 8a06699 into pingcap:master May 25, 2021
@morgo morgo deleted the fix-sysvar-caching branch May 25, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sysvar cache for globals in show variables is incorrect.
5 participants