Skip to content

Conversation

TennyZhuang
Copy link
Contributor

@TennyZhuang TennyZhuang commented May 10, 2021

What problem does this PR solve?

Problem Summary:

Upgrade to go 1.16

And Deprecation of io/ioutil

What is changed and how it works?

How it Works:

fastmod --accept-all -e go "ioutil\.WriteFile" "os.WriteFile"
fastmod --accept-all -e go "ioutil\.TempFile" "os.CreateTemp"
fastmod --accept-all -e go "ioutil\.TempDir" "os.MkdirTemp"
fastmod --accept-all -e go "ioutil\.ReadFile" "os.ReadFile"
fastmod --accept-all -e go "ioutil\.ReadAll" "io.ReadAll"
fastmod --accept-all -e go "ioutil\.ReadDir" "os.ReadDir"
fastmod --accept-all -e go "ioutil\.NopCloser" "io.NopCloser"
fastmod --accept-all -e go "ioutil\.Discard" "io.Discard"

goimports -w .

And a little manual fix in slow_query.go getAllFiles

Related changes

Check List

Tests

  • Unit test

Side effects

Release note

  • No release note

@TennyZhuang TennyZhuang requested review from a team as code owners May 10, 2021 12:52
@TennyZhuang TennyZhuang requested review from qw4990 and removed request for a team May 10, 2021 12:52
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 10, 2021
@ti-srebot
Copy link
Contributor

@TennyZhuang TennyZhuang force-pushed the ioutil-deprecation branch from 053ac68 to 31d7448 Compare May 10, 2021 13:06
@TennyZhuang TennyZhuang changed the title *: remove deprecated io/ioutil *: Upgrade to go 1.16 && remove deprecated io/ioutil May 10, 2021
@TennyZhuang TennyZhuang force-pushed the ioutil-deprecation branch from 31d7448 to 4860bd4 Compare May 10, 2021 13:11
@tisonkun
Copy link
Contributor

ref #22198

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2021
@tisonkun
Copy link
Contributor

@TennyZhuang it seems go mod tidy generated a different go.sum file. Please resolve diff and push updates.

@purelind
Copy link
Contributor

/run-build

@bb7133
Copy link
Member

bb7133 commented May 24, 2021

/rebuild

@bb7133
Copy link
Member

bb7133 commented May 24, 2021

/run-all-tests

1 similar comment
@zhouqiang-cl
Copy link
Contributor

/run-all-tests

@zhouqiang-cl
Copy link
Contributor

/run-e2e-test

@zhouqiang-cl
Copy link
Contributor

/run-unit-tests

@bb7133
Copy link
Member

bb7133 commented May 24, 2021

Hi @TennyZhuang , we've updated the plugin codes, now the build is fine, thanks for your efforts.

@ti-chi-bot
Copy link
Member

@tisonkun: Thanks for your review. The bot only counts /lgtm from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tisonkun
Copy link
Contributor

/cc @bb7133 @XuHuaiyu

@ti-chi-bot ti-chi-bot requested review from bb7133 and XuHuaiyu May 24, 2021 15:40
@zhouqiang-cl
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@zhouqiang-cl: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@morgo
Copy link
Contributor

morgo commented May 24, 2021

/merge

@ti-chi-bot
Copy link
Member

@morgo: /merge in this pull request requires 2 /lgtm.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@morgo
Copy link
Contributor

morgo commented May 24, 2021

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 24, 2021
@zhouqiang-cl
Copy link
Contributor

/run-e2e-test

@bb7133
Copy link
Member

bb7133 commented May 25, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 25, 2021
@bb7133
Copy link
Member

bb7133 commented May 25, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 86111ce

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 25, 2021
@ti-chi-bot
Copy link
Member

@TennyZhuang: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@morgo
Copy link
Contributor

morgo commented May 25, 2021

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 39bd181 into pingcap:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/config component/expression sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants