-
Notifications
You must be signed in to change notification settings - Fork 6k
*: Upgrade to go 1.16 && remove deprecated io/ioutil #24527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
053ac68
to
31d7448
Compare
31d7448
to
4860bd4
Compare
ref #22198 |
@TennyZhuang it seems |
Signed-off-by: tison <wander4096@gmail.com>
Ioutil deprecation patch 1
/run-build |
/rebuild |
/run-all-tests |
1 similar comment
/run-all-tests |
/run-e2e-test |
/run-unit-tests |
Hi @TennyZhuang , we've updated the plugin codes, now the build is fine, thanks for your efforts. |
@tisonkun: Thanks for your review. The bot only counts In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
@zhouqiang-cl: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
@morgo: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/LGTM |
/run-e2e-test |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 86111ce
|
@TennyZhuang: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-unit-test |
What problem does this PR solve?
Problem Summary:
Upgrade to go 1.16
And Deprecation of io/ioutil
What is changed and how it works?
How it Works:
And a little manual fix in slow_query.go
getAllFiles
Related changes
Check List
Tests
Side effects
Release note