Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: create new column slice in PreparePossibleProperties #24342

Merged
merged 5 commits into from
May 11, 2021
Merged

planner: create new column slice in PreparePossibleProperties #24342

merged 5 commits into from
May 11, 2021

Conversation

francis0407
Copy link
Member

@francis0407 francis0407 commented Apr 28, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #24281

Problem Summary:

Actually, the root cause of the issue is that the LogicalAggregation.possibleProperties is modified by (p *LogicalProjection) PreparePossibleProperties, which is unexpected. Hence, the Aggregation generates a wrong requiredProperty for its child.

What is changed and how it works?

What's Changed:

This PR just creates a new slice for the possibleProperties instead of a in-place update.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test

Release note

  • fix "index out of range" error when a SQL contains both group by and union.

@francis0407 francis0407 requested a review from a team as a code owner April 28, 2021 06:35
@francis0407 francis0407 requested review from hanfei1991 and removed request for a team April 28, 2021 06:35
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 28, 2021
@francis0407
Copy link
Member Author

/cc @winoros

@ti-chi-bot ti-chi-bot requested a review from winoros April 28, 2021 06:50
@ichn-hu ichn-hu mentioned this pull request Apr 28, 2021
Closed
@francis0407
Copy link
Member Author

cc @lzmhhh123

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 30, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lzmhhh123
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 11, 2021
@winoros
Copy link
Member

winoros commented May 11, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f16ed42

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 11, 2021
@winoros
Copy link
Member

winoros commented May 11, 2021

/merge

@ti-chi-bot ti-chi-bot merged commit 7d41c86 into pingcap:master May 11, 2021
@bb7133
Copy link
Member

bb7133 commented May 11, 2021

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 11, 2021
@francis0407 @ti-srebot
cherry pick pingcap#24342 to release-5.0
bae0753 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 11, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #24551

ti-chi-bot pushed a commit that referenced this pull request Jun 1, 2021
@ti-srebot
planner: create new column slice in PreparePossibleProperties (#24342) (
3f945b7 
#24551)
winoros pushed a commit to winoros/tidb that referenced this pull request Jul 25, 2021
@francis0407 @winoros
planner: create new column slice in PreparePossibleProperties (pingca…
9fb39ea 
…p#24342)
zhouqiang-cl pushed a commit that referenced this pull request Jul 25, 2021
@winoros @francis0407
planner: create new column slice in PreparePossibleProperties (#24342) (
5f0d4ad 
#26536)

Co-authored-by: Mingcong Han <hanmingcong123@hotmail.com>
ti-chi-bot pushed a commit that referenced this pull request Jul 26, 2021
@ti-srebot
planner: create new column slice in PreparePossibleProperties (#24342) (
2b41f1c 
#26536) (#26553)
@guo-shaoge
Copy link
Collaborator

/label needs-cherry-pick-4.0

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 9, 2021
@francis0407 @ti-srebot
cherry pick pingcap#24342 to release-4.0
7df4477 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 9, 2021
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #27929

@myccccccc myccccccc mentioned this pull request Oct 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@hanfei1991 hanfei1991 Awaiting requested review from hanfei1991

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

out of index[-1] for ColumnIndex
7 participants
@francis0407 @ti-chi-bot @winoros @bb7133 @ti-srebot @guo-shaoge @lzmhhh123