Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: clone possible properties before saving them #24204

Merged
merged 1 commit into from
Apr 28, 2021
Merged

planner: clone possible properties before saving them #24204

merged 1 commit into from
Apr 28, 2021

Conversation

eurekaka
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #24045

Problem Summary:

Planner reports error when compiling a query.

What is changed and how it works?

What's Changed:

Clone the columns in the possible properties before saving them in LogicalAggregation / LogicalJoin, otherwise if these properties pass through upper LogicalProjection, the columns below may be modified, and lead to panic.

Related changes

N/A

Check List

Tests

  • Unit test

Side effects

  • Performance regression
    • Consumes more MEM

Release note

  • Fix panic when building plan for a query containing HAVING clause.

@eurekaka eurekaka added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Apr 22, 2021
@eurekaka eurekaka requested a review from a team as a code owner April 22, 2021 09:12
@eurekaka eurekaka requested review from lzmhhh123 and removed request for a team April 22, 2021 09:12
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 22, 2021
@eurekaka eurekaka requested review from time-and-fate and winoros and removed request for lzmhhh123 April 22, 2021 09:13
@zhouqiang-cl
Copy link
Contributor

/run-unit-tests

@ichn-hu ichn-hu mentioned this pull request Apr 22, 2021
Closed
time-and-fate
time-and-fate approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@time-and-fate time-and-fate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 28, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • time-and-fate
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 28, 2021
@winoros
Copy link
Member

winoros commented Apr 28, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f42f830c51f92e8b73c5536df1ecdc4d5657fa76

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 28, 2021
@eurekaka
Copy link
Contributor Author

/run-mybatis-test

@eurekaka
Copy link
Contributor Author

/run-check_dev_2
/run-unit-test

@eurekaka
Copy link
Contributor Author

/run-unit-test

@eurekaka
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Apr 28, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

@ti-chi-bot ti-chi-bot merged commit b7838d8 into pingcap:master Apr 28, 2021
@eurekaka eurekaka deleted the having branch May 8, 2021 09:02
@ti-srebot ti-srebot mentioned this pull request May 8, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #24489

eurekaka added a commit to ti-srebot/tidb that referenced this pull request May 8, 2021
@eurekaka
cherry pick pingcap#24204 to release-5.0
934c9aa 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-chi-bot pushed a commit that referenced this pull request May 31, 2021
@ti-srebot
planner: clone possible properties before saving them (#24204) (#24489)
bdc9089
This was referenced Oct 12, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected query result with server error
7 participants
@eurekaka @zhouqiang-cl @ti-chi-bot @winoros @sre-bot @ti-srebot @time-and-fate