Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: make column default value being aware of NO_ZERO_IN_DATE (#24174) #24186

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Apr 21, 2021

cherry-pick #24174 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/24186

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/24186:release-5.0-2e52da6b37d7

What problem does this PR solve?

Issue Number: close #24165

Problem Summary:

ResetContextOfStmt() does not set IgnoreZeroInDate to the statement context, resulting in a parse error about zero-date default value.

What is changed and how it works?

What's Changed: Reset AllowInvalidDate and IgnoreZeroInDate for create table statements.

Related changes

NA

Check List

Tests

  • Unit test
  • Integration test

Side effects

NA

Release note

  • Fix an issue that NO_ZERO_IN_DATE SQL mode does not work in default value

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-srebot ti-srebot requested a review from a team as a code owner April 21, 2021 07:10
@ti-srebot ti-srebot requested review from wshwsh12 and removed request for a team April 21, 2021 07:10
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added sig/execution SIG execution size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.0-cherry-pick type/bugfix This PR fixes a bug. labels Apr 21, 2021
@ti-srebot ti-srebot added this to the v5.0.1 milestone Apr 21, 2021
@ti-srebot
Copy link
Contributor Author

@tangenta you're already a collaborator in bot's repo.

@dianqihanwangzi
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 21, 2021
@wshwsh12 wshwsh12 removed their request for review June 4, 2021 07:21
@lzmhhh123 lzmhhh123 removed their request for review July 5, 2021 02:10
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 12, 2021
@tangenta
Copy link
Contributor

tangenta commented Sep 2, 2021

The changes has been included in #26903.

@tangenta tangenta closed this Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. sig/execution SIG execution size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/5.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants