-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: make column default value being aware of NO_ZERO_IN_DATE (#24174) #24186
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/run-all-tests |
@tangenta you're already a collaborator in bot's repo. |
/run-all-tests |
The changes has been included in #26903. |
cherry-pick #24174 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/24186
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #24165
Problem Summary:
ResetContextOfStmt()
does not setIgnoreZeroInDate
to the statement context, resulting in a parse error about zero-date default value.What is changed and how it works?
What's Changed: Reset
AllowInvalidDate
andIgnoreZeroInDate
for create table statements.Related changes
NA
Check List
Tests
Side effects
NA
Release note
NO_ZERO_IN_DATE
SQL mode does not work in default value