Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix null div 0 for partition key expression is incorrect #24098

Merged
merged 17 commits into from
Apr 19, 2021
Merged

executor: fix null div 0 for partition key expression is incorrect #24098

merged 17 commits into from
Apr 19, 2021

Conversation

Howie59
Copy link
Contributor

@Howie59 Howie59 commented Apr 17, 2021

What problem does this PR solve?

Issue Number: close #24091

Check List

Tests

  • Unit test

Release note

  • No release note

@Howie59 Howie59 requested a review from a team as a code owner April 17, 2021 04:33
@Howie59 Howie59 requested review from lzmhhh123 and removed request for a team April 17, 2021 04:33
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 17, 2021
@Howie59 Howie59 changed the title ddl: fix null div 0 for partition key expression is incorrect executor: fix null div 0 for partition key expression is incorrect Apr 19, 2021
@mmyj
Copy link
Member

mmyj commented Apr 19, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 19, 2021
@mmyj
Copy link
Member

mmyj commented Apr 19, 2021

/lgtm cancel

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Apr 19, 2021
@mmyj
Copy link
Member

mmyj commented Apr 19, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 19, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lzmhhh123
  • mmyj

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 19, 2021
@lzmhhh123
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b928f23

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 19, 2021
@ti-chi-bot
Copy link
Member

@Howie59: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 36b04d1 into pingcap:master Apr 19, 2021
@Howie59 Howie59 deleted the issue-24091 branch April 19, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmyj mmyj mmyj left review comments

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

Assignees
No one assigned
Labels
component/expression sig/execution SIG execution size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

null div 0 for partition key expression is incorrect
4 participants
@Howie59 @mmyj @ti-chi-bot @lzmhhh123