Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

telemetry: Fix window algorithm #23518

Merged
merged 2 commits into from
Mar 25, 2021
Merged

telemetry: Fix window algorithm #23518

merged 2 commits into from
Mar 25, 2021

Conversation

breezewish
Copy link
Member

@breezewish breezewish commented Mar 24, 2021 •
edited
Loading

What problem does this PR solve?

Fix the issue that telemetry window is wrong calculated or panics.

What is changed and how it works?

  1. Data Collector: Always report to a global counters
  2. Data Rotater: Rotate global counters to a local buffer, every 1 minute.
  3. Data Reporter: Aggregate everything in the local buffer, by every 1 hour window, then upload.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test: Change WindowSize to 1m and SubWindowSize to 1s to test

Release note

  • Fix telemetry window algorithm

@breezewish breezewish requested a review from a team as a code owner March 24, 2021 17:57
@breezewish breezewish requested review from XuHuaiyu and removed request for a team March 24, 2021 17:57
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 24, 2021
@ti-srebot
Copy link
Contributor

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@breezewish
Copy link
Member Author

/run-all-tests

@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Mar 24, 2021
@ti-chi-bot
Copy link
Member

@lzmhhh123: /lgtm is only allowed for the reviewers in list.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@kaixu120811
Copy link
Collaborator

LGTM

@ti-chi-bot
Copy link
Member

@kaixu120811: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lzmhhh123 lzmhhh123 added the sig/execution SIG execution label Mar 25, 2021
@lzmhhh123
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 25, 2021
@lzmhhh123 lzmhhh123 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 25, 2021
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Mar 25, 2021
@lysu
Copy link
Contributor

lysu commented Mar 25, 2021

/LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lysu
  • lzmhhh123

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 25, 2021
@lysu
Copy link
Contributor

lysu commented Mar 25, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: efc9afc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 25, 2021
@ti-chi-bot ti-chi-bot merged commit 4b7a376 into pingcap:master Mar 25, 2021
SabaPing pushed a commit to SabaPing/tidb that referenced this pull request Mar 25, 2021
@breezewish @SabaPing
telemetry: Fix window algorithm (pingcap#23518)
49e90ab
@breezewish breezewish deleted the fix-telemetry-window branch March 25, 2021 07:12
breezewish added a commit to ti-srebot/tidb that referenced this pull request Mar 25, 2021
@breezewish
telemetry: Fix window algorithm (pingcap#23518)
c447ee9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@breezewish @ti-srebot @ti-chi-bot @kaixu120811 @lzmhhh123 @lysu